quic: update ngtcp2 and nghttp3 - #34752
Closed
jasnell wants to merge 5 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
jasnell
force-pushed
the
quic-cleanups-15
branch
from
8db5de9 to
34a5737
Compare
August 12, 2020 23:10
jasnell
marked this pull request as ready for review
August 12, 2020 23:13
This comment has been minimized.
This comment has been minimized.
jasnell
force-pushed
the
quic-cleanups-15
branch
from
b19ba30 to
108ace4
Compare
August 13, 2020 00:59
jasnell
marked this pull request as draft
August 13, 2020 14:35
This comment has been minimized.
jasnell
force-pushed
the
quic-cleanups-15
branch
9 times, most recently
from
f6019aa to
63f8190
Compare
August 19, 2020 14:51
This comment has been minimized.
jasnell
force-pushed
the
quic-cleanups-15
branch
2 times, most recently
from
d9a17dc to
8d1a064
Compare
August 19, 2020 16:13
This comment has been minimized.
This comment has been minimized.
jasnell
force-pushed
the
quic-cleanups-15
branch
2 times, most recently
from
76beaae to
5e7a4cf
Compare
August 20, 2020 20:27
9 tasks
gengjiawen
approved these changes
Aug 21, 2020
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
approved these changes
Aug 21, 2020
Comment thread
src/quic/node_quic_session.cc
Outdated
jasnell
force-pushed
the
quic-cleanups-15
branch
2 times, most recently
from
8e1adca to
254ce5a
Compare
August 21, 2020 16:07
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
quic-cleanups-15
branch
from
254ce5a to
923a9c0
Compare
August 21, 2020 16:09
jasnell
added a commit
that referenced
this pull request
Aug 21, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #34752 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell
added a commit
that referenced
this pull request
Aug 21, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #34752 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell
added a commit
that referenced
this pull request
Aug 21, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #34752 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell
added a commit
that referenced
this pull request
Aug 21, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #34752 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell
added a commit
that referenced
this pull request
Aug 21, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #34752 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Aug 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the deps ngtcp2 and nghttp3 to latest + needed fixups. This depends directly on the prior PRs #34655, #34669, and #34741 landing first (all of which are ready to land except for the silly mandatory wait time requirement)
Checklist