FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v10.x] build: expose napi_build_version variable by gabrielschulhof · Pull Request #35266 · nodejs/node · GitHub

/ node Public

[v10.x] build: expose napi_build_version variable - #35266

Closed
gabrielschulhof wants to merge 1 commit into
nodejs:v10.x-stagingfrom
gabrielschulhof:backport-napi_build_version-to-v10.x
ConversationCommits (1)ChecksFiles changed
Closed

[v10.x] build: expose napi_build_version variable#35266
gabrielschulhof wants to merge 1 commit into
nodejs:v10.x-stagingfrom
gabrielschulhof:backport-napi_build_version-to-v10.x

Conversation

gabrielschulhof commented Sep 19, 2020

Copy link
Copy Markdown
Contributor

Expose napi_build_version to allow node-gyp to make it
available for building native addons.

Fixes: nodejs/node-gyp#1745
Refs: nodejs/abi-stable-node#371
PR-URL: #27835
Reviewed-By: @bnoordhuis
Reviewed-By: @addaleax
Reviewed-By: @gabrielschulhof
Reviewed-By: @lpinca
Reviewed-By: @richardlau
Reviewed-By: @mhdawson

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. v10.x labels Sep 19, 2020
gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Sep 19, 2020
build: expose napi_build_version variable
248df1b 
Expose `napi_build_version` to allow `node-gyp` to make it
available for building native addons.

Fixes: nodejs/node-gyp#1745
Refs: nodejs/abi-stable-node#371
PR-URL: nodejs#27835
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gabrielschulhof force-pushed the backport-napi_build_version-to-v10.x branch from bf373c5 to 248df1b Compare September 19, 2020 03:46

gabrielschulhof commented Sep 19, 2020

Copy link
Copy Markdown
Contributor Author

@NickNaso can you please link the issue that has recently cropped up because we forgot to backport this PR?

mhdawson approved these changes Sep 22, 2020
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, this seems very low risk and we had an issue reported where a N-API module failed to build because it could not check the value.

NickNaso commented Sep 22, 2020

Copy link
Copy Markdown
Member

Hi everybody sorry for the late.
The issue was opened on node-gyp repo nodejs/node-gyp#2224

richardlau commented Sep 22, 2020

Copy link
Copy Markdown
Member

Are there likely to be any other n-api related things that need to land on 10.x? We don't have any regular scheduled releases for 10.x now it is in maintenance1 so I'm trying to gauge how much content we'll have to put out in a release.

1To clarify, I'm okay with this landing on 10.x, just working through the logistics of how we actually get it into what release.

nodejs-github-bot commented Sep 25, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33236/

gabrielschulhof commented Sep 25, 2020

Copy link
Copy Markdown
Contributor Author

@richardlau the PR that marks N-API 7 as stable must still land.

gabrielschulhof commented Sep 25, 2020

Copy link
Copy Markdown
Contributor Author

@richardlau #35336

richardlau commented Sep 25, 2020

Copy link
Copy Markdown
Member

@richardlau the PR that marks N-API 7 as stable must still land.

Thanks. FWIW we discussed the plan for Node.js v10.x at the most recent Release WG meeting (nodejs/Release#614) and the current idea is to look to do a release in about a month's time.

richardlau pushed a commit that referenced this pull request Oct 7, 2020
build: expose napi_build_version variable
b83f9a5 
Expose `napi_build_version` to allow `node-gyp` to make it
available for building native addons.

Fixes: nodejs/node-gyp#1745
Refs: nodejs/abi-stable-node#371
PR-URL: #27835
Backport-PR-URL: #35266
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

richardlau commented Oct 7, 2020

Copy link
Copy Markdown
Member

Landed in b83f9a5.

richardlau closed this Oct 7, 2020
gabrielschulhof mentioned this pull request Oct 7, 2020
Closed
gabrielschulhof deleted the backport-napi_build_version-to-v10.x branch January 28, 2021 00:14
gabrielschulhof restored the backport-napi_build_version-to-v10.x branch January 28, 2021 05:40
gabrielschulhof deleted the backport-napi_build_version-to-v10.x branch February 3, 2021 07:17
roman-r-m mentioned this pull request Mar 13, 2021
Closed
roman-r-m mentioned this pull request May 2, 2021
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. node-api Issues and PRs related to the Node-API. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL