FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v10.x] n-api: create N-API version 7 by gabrielschulhof · Pull Request #35336 · nodejs/node · GitHub

/ node Public

[v10.x] n-api: create N-API version 7 - #35336

Closed
gabrielschulhof wants to merge 1 commit into
nodejs:v10.x-stagingfrom
gabrielschulhof:backport-n-api-7-to-v10.x
ConversationCommits (1)ChecksFiles changed
Closed

[v10.x] n-api: create N-API version 7#35336
gabrielschulhof wants to merge 1 commit into
nodejs:v10.x-stagingfrom
gabrielschulhof:backport-n-api-7-to-v10.x

Conversation

gabrielschulhof commented Sep 25, 2020

Copy link
Copy Markdown
Contributor

Mark napi_detach_arraybuffer and napi_is_detached_arraybuffer as
stable.

Signed-off-by: @gabrielschulhof
PR-URL: #35199
Reviewed-By: @cjihrig
Reviewed-By: @gengjiawen
Reviewed-By: @legendecas
Reviewed-By: @mhdawson

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

n-api: create N-API version 7
2320140 
Mark `napi_detach_arraybuffer` and `napi_is_detached_arraybuffer` as
stable.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: nodejs#35199
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <mdawson@devrus.com>
gabrielschulhof added node-api Issues and PRs related to the Node-API. v10.x labels Sep 25, 2020

nodejs-github-bot commented Sep 25, 2020 •
edited by mhdawson
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/n-api

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 25, 2020
gabrielschulhof mentioned this pull request Sep 25, 2020
Closed
4 tasks
legendecas approved these changes Sep 25, 2020
View reviewed changes

legendecas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

lundibundi approved these changes Sep 25, 2020
View reviewed changes
Comment thread test/addons-napi/test_general/test.js
// test version management functions
// expected version is currently 4
assert.strictEqual(test_general.testGetVersion(), 6);
assert.strictEqual(test_general.testGetVersion(), 7);

lundibundi Sep 25, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think the comment above should've also been changed but since this is a backport it's fine like this.

mhdawson approved these changes Sep 25, 2020
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2020
richardlau approved these changes Sep 25, 2020
View reviewed changes

richardlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@gabrielschulhof Should this update the N-API version matrix table?

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2020

nodejs-github-bot commented Sep 25, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33240/

mhdawson commented Sep 25, 2020

Copy link
Copy Markdown
Member

@richardlau looks like we missed updating the matrix in master, opened #35345 to discuss how we might do that. Given that we don't know the versions in advance, I think we've deferred backporting the matrix

nodejs-github-bot commented Sep 25, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33244/

richardlau pushed a commit that referenced this pull request Oct 7, 2020
n-api: create N-API version 7
54c2bc2 
Mark `napi_detach_arraybuffer` and `napi_is_detached_arraybuffer` as
stable.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #35199
Backport-PR-URL: #35336
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <mdawson@devrus.com>

richardlau commented Oct 7, 2020

Copy link
Copy Markdown
Member

Landed in 54c2bc2.

richardlau closed this Oct 7, 2020
gabrielschulhof deleted the backport-n-api-7-to-v10.x branch January 28, 2021 00:14
gabrielschulhof restored the backport-n-api-7-to-v10.x branch January 28, 2021 05:40
gabrielschulhof deleted the backport-n-api-7-to-v10.x branch February 3, 2021 07:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gengjiawen gengjiawen approved these changes
richardlau richardlau approved these changes
legendecas legendecas approved these changes
+2 more reviewers
lundibundi lundibundi approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL