FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: refactor the n-api matrix by mhdawson · Pull Request #35345 · nodejs/node · GitHub

/ node Public

doc: refactor the n-api matrix - #35345

Closed
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:napi-matrix-refactor
ConversationCommits (1)ChecksFiles changed
Closed

doc: refactor the n-api matrix#35345
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:napi-matrix-refactor

Conversation

mhdawson commented Sep 25, 2020

Copy link
Copy Markdown
Member
  • refactor the n-api matrix and add v7

Signed-off-by: Michael Dawson mdawson@devrus.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Sep 25, 2020

nodejs-github-bot commented Sep 25, 2020 •
edited by mhdawson
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/n-api

mhdawson marked this pull request as draft September 25, 2020 14:37

mhdawson commented Sep 25, 2020

Copy link
Copy Markdown
Member Author

Marked as draft as I think we need to change the format of the table, and wanted to get some feedback on this approach.

mhdawson commented Sep 25, 2020

Copy link
Copy Markdown
Member Author

@nodejs/n-api

mhdawson mentioned this pull request Sep 25, 2020
Closed
4 tasks
mhdawson commented Sep 25, 2020
View reviewed changes
Comment thread doc/api/n-api.md Outdated

mhdawson commented Sep 25, 2020

Copy link
Copy Markdown
Member Author

Talked it over with in the N-API team meeting today, seems like people were ok with the approach, removing out of draft.

mhdawson marked this pull request as ready for review September 25, 2020 15:48

mhdawson commented Sep 25, 2020

Copy link
Copy Markdown
Member Author

This should probably land https://github.com/nodejs/node/pull/35319/files and then I can rebase this PR on top of it.

mhdawson commented Sep 30, 2020

Copy link
Copy Markdown
Member Author

See that #35319 has landed, will rebase tomorrow

mhdawson commented Oct 1, 2020

Copy link
Copy Markdown
Member Author

Rebased, will wait for checks to complete and then land.

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2020

nodejs-github-bot commented Oct 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33397/

aduh95 reviewed Oct 5, 2020
View reviewed changes
Comment thread doc/api/n-api.md Outdated

gabrielschulhof commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

N-API 7 has since been released in v12.19.0.

mhdawson commented Oct 9, 2020

Copy link
Copy Markdown
Member Author

Updated to include N-API 7 beeing released in v12.19.0.

doc: refactor the n-api matrix
8d97f90 
- refactor the n-api matrix and add v7

Signed-off-by: Michael Dawson <mdawson@devrus.com>
mhdawson force-pushed the napi-matrix-refactor branch from 5f89cc2 to 8d97f90 Compare October 9, 2020 17:10
mhdawson added a commit that referenced this pull request Oct 9, 2020
doc: refactor the n-api matrix
ccfa661 
- refactor the n-api matrix and add v7

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #35345
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

mhdawson commented Oct 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Landed in ccfa661

mhdawson closed this Oct 9, 2020

richardlau commented Oct 9, 2020

Copy link
Copy Markdown
Member

@mhdawson Do we want this backported for v10.23.0 (manually, with an entry added for it) (#35544)? Currently the v10.x docs do not even list N-API 6:

(or maybe an alternative would be put some words asking readers to consult the table in the current "current" version?)

BethGriggs pushed a commit that referenced this pull request Oct 14, 2020
doc: refactor the n-api matrix
863ba4b 
- refactor the n-api matrix and add v7

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #35345
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MylesBorins mentioned this pull request Oct 14, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
doc: refactor the n-api matrix
105a50c 
- refactor the n-api matrix and add v7

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#35345
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
legendecas legendecas approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL