FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v12.x backport] fs: add .ref() and .unref() methods to watcher classes by lpinca · Pull Request #35555 · nodejs/node · GitHub

/ node Public

[v12.x backport] fs: add .ref() and .unref() methods to watcher classes - #35555

Closed
lpinca wants to merge 1 commit into
nodejs:v12.x-stagingfrom
lpinca:backport-33134-to-v12.x
ConversationCommits (1)ChecksFiles changed
Closed

[v12.x backport] fs: add .ref() and .unref() methods to watcher classes#35555
lpinca wants to merge 1 commit into
nodejs:v12.x-stagingfrom
lpinca:backport-33134-to-v12.x

Conversation

lpinca commented Oct 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

PR-URL: #33134
Fixes: #33096
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

fs: add .ref() and .unref() methods to watcher classes
ce9022d 
PR-URL: nodejs#33134
Fixes: nodejs#33096
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v12.x labels Oct 8, 2020

lpinca commented Oct 8, 2020

Copy link
Copy Markdown
Member Author

cc: @rickyes

lpinca changed the title fs: add .ref() and .unref() methods to watcher classes [v12.x backport] fs: add .ref() and .unref() methods to watcher classes Oct 8, 2020
rickyes approved these changes Oct 8, 2020
View reviewed changes

rickyes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2020
rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2020

nodejs-github-bot commented Oct 8, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33474/

rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2020

nodejs-github-bot commented Oct 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33489/

rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2020

nodejs-github-bot commented Oct 10, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33510/

rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020

nodejs-github-bot commented Oct 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33563/

rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020

nodejs-github-bot commented Oct 13, 2020 •
edited by rickyes
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33567/ ✅

MylesBorins added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 15, 2020
rickyes added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 28, 2020
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
fs: add .ref() and .unref() methods to watcher classes
3e297cf 
Backport-PR-URL: #35555
PR-URL: #33134
Fixes: #33096
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins commented Nov 3, 2020

Copy link
Copy Markdown
Contributor

landed in 3e297cf

MylesBorins closed this Nov 3, 2020
lpinca deleted the backport-33134-to-v12.x branch November 3, 2020 17:43
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
fs: add .ref() and .unref() methods to watcher classes
decfc2a 
Backport-PR-URL: #35555
PR-URL: #33134
Fixes: #33096
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
fhinkel fhinkel approved these changes
rickyes rickyes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL