FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stabilize packages features by MylesBorins · Pull Request #35742 · nodejs/node · GitHub

/ node Public

stabilize packages features - #35742

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:mark-features-stable
ConversationCommits (1)ChecksFiles changed
Closed

stabilize packages features#35742
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:mark-features-stable

Conversation

MylesBorins commented Oct 21, 2020

Copy link
Copy Markdown
Contributor

These features are being used in production and are ready to be
considered stable.

Refs: nodejs/modules#564

Depends on #35741

/cc @nodejs/modules

nodejs-github-bot commented Oct 21, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/modules

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 21, 2020
MylesBorins mentioned this pull request Oct 21, 2020
Closed
GeoffreyBooth reviewed Oct 21, 2020
View reviewed changes
Comment thread doc/api/packages.md Outdated

GeoffreyBooth Oct 21, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think @guybedford deliberately wanted this below "exports" because we want people to be preferring "exports" over "main".

MylesBorins Oct 21, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

the ordering is changed in #35741

I can update it there

guybedford Oct 21, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not tied to the ordering, it just a suggestion previously since there was no explicit ordering (it not being alphabetical).

Trott Oct 22, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe the list on L825 can have its ordering stated ("In order of precedence, the possible entries are:") while the headers can be in alphabetical order?

Comment thread doc/api/packages.md Outdated
MylesBorins mentioned this pull request Oct 21, 2020
Closed
4 tasks

This comment has been minimized.

Sign in to view
mcollina approved these changes Oct 22, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

Trott commented Oct 22, 2020

Copy link
Copy Markdown
Member

This probably shouldn't land before the runtime deprecation in #35747 because otherwise that runtime deprecation is semver-major?

Trott added the blocked PRs that are blocked by other issues or PRs. label Oct 22, 2020
Trott reviewed Oct 22, 2020
View reviewed changes
Comment thread doc/api/packages.md Outdated

MylesBorins commented Oct 22, 2020

Copy link
Copy Markdown
Contributor Author

@Trott the folder pathing stuff is currently no longer documented and unaffected by this change

doc: stabilize packages features
c9a55e3 
These features are being used in production and are ready to be
considered stable.

Refs: nodejs/modules#564
MylesBorins removed the blocked PRs that are blocked by other issues or PRs. label Oct 26, 2020

MylesBorins commented Oct 26, 2020

Copy link
Copy Markdown
Contributor Author

@nodejs/modules I would like to land this. If there are no objections within 24 hours I will land it tomorrow.

@Trott I removed your blocked label as I don't believe the feature you pointed out is affected by this change. Please let me know if you think I'm mistaken

MylesBorins commented Oct 29, 2020

Copy link
Copy Markdown
Contributor Author

Landed in acdfc16

MylesBorins deleted the mark-features-stable branch October 29, 2020 14:24
MylesBorins added a commit that referenced this pull request Oct 29, 2020
doc: stabilize packages features
acdfc16 
These features are being used in production and are ready to be
considered stable.

Refs: nodejs/modules#564

PR-URL: #35742
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Nov 3, 2020
doc: stabilize packages features
d291e3a 
These features are being used in production and are ready to be
considered stable.

Refs: nodejs/modules#564

PR-URL: #35742
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Nov 3, 2020
Merged
guybedford mentioned this pull request Nov 23, 2020
Closed
3 tasks
MylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label Nov 24, 2020
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
doc: stabilize packages features
ae5e510 
These features are being used in production and are ready to be
considered stable.

Refs: nodejs/modules#564

PR-URL: #35742
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 29, 2021
doc: stabilize packages features
a7da993 
These features are being used in production and are ready to be
considered stable.

Refs: nodejs/modules#564

PR-URL: #35742
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
mildsunrise mentioned this pull request Sep 2, 2021
Closed
targos removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

guybedford guybedford approved these changes
mcollina mcollina approved these changes
jasnell jasnell approved these changes
GeoffreyBooth GeoffreyBooth approved these changes
Trott Trott approved these changes
+2 more reviewers
fhinkel fhinkel approved these changes
ryzokuken ryzokuken approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL