FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: add startup benchmark for loading public modules by joyeecheung · Pull Request #35816 · nodejs/node · GitHub

/ node Public

benchmark: add startup benchmark for loading public modules - #35816

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:built-bench
ConversationCommits (1)ChecksFiles changed
Closed

benchmark: add startup benchmark for loading public modules#35816
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:built-bench

Conversation

joyeecheung commented Oct 26, 2020

Copy link
Copy Markdown
Member

Adding a new benchmark for testing the performance of loading
available public modules.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

benchmark: add startup benchmark for loading public modules
2ce2244 
Adding a new benchmark for testing the performance of loading
available public modules.
nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Oct 26, 2020

nodejs-github-bot commented Oct 26, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020

nodejs-github-bot commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33908/

ZYSzys reviewed Oct 29, 2020
View reviewed changes
Comment thread benchmark/fixtures/require-builtins.js
'util',
'vm',
'zlib',
];

ZYSzys Oct 29, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hardcode was likely missed some modules, just like v8, worker_threads here.

Can we directly use require('module').builtinModules ?

joyeecheung Oct 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@ZYSzys That way we may not be able to get fair results on different versions of Node.js (some of them may have more modules)

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2020

nodejs-github-bot commented Oct 30, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33968/

joyeecheung added a commit that referenced this pull request Nov 4, 2020
benchmark: add startup benchmark for loading public modules
38c1569 
Adding a new benchmark for testing the performance of loading
available public modules.

PR-URL: #35816
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

joyeecheung commented Nov 4, 2020

Copy link
Copy Markdown
Member Author

Landed in 38c1569, thanks!

joyeecheung closed this Nov 4, 2020
targos pushed a commit that referenced this pull request Nov 4, 2020
benchmark: add startup benchmark for loading public modules
9b549c1 
Adding a new benchmark for testing the performance of loading
available public modules.

PR-URL: #35816
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Nov 4, 2020
Merged
richardlau added a commit to richardlau/node-1 that referenced this pull request Nov 4, 2020
benchmark: remove modules that require intl
893ac61 
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: nodejs#35816
This was referenced Nov 4, 2020
Closed
Closed
nodejs-github-bot pushed a commit that referenced this pull request Nov 5, 2020
benchmark: remove modules that require intl
540b796 
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: #35816

PR-URL: #35968
Fixes: #35962
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

richardlau commented Nov 5, 2020

Copy link
Copy Markdown
Member

If backported, this should land with #35968.

danielleadams pushed a commit that referenced this pull request Nov 9, 2020
benchmark: remove modules that require intl
4c6de85 
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: #35816

PR-URL: #35968
Fixes: #35962
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
benchmark: add startup benchmark for loading public modules
19eb050 
Adding a new benchmark for testing the performance of loading
available public modules.

PR-URL: #35816
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
benchmark: remove modules that require intl
931bae3 
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: #35816

PR-URL: #35968
Fixes: #35962
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
benchmark: add startup benchmark for loading public modules
9f0b1e3 
Adding a new benchmark for testing the performance of loading
available public modules.

PR-URL: #35816
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
benchmark: remove modules that require intl
37b7a27 
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: #35816

PR-URL: #35968
Fixes: #35962
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
benchmark: add startup benchmark for loading public modules
21d3ccf 
Adding a new benchmark for testing the performance of loading
available public modules.

PR-URL: #35816
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
benchmark: remove modules that require intl
fdb1c0d 
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: #35816

PR-URL: #35968
Fixes: #35962
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZYSzys ZYSzys left review comments
jasnell jasnell approved these changes
Trott Trott approved these changes

Assignees

No one assigned

Labels

benchmark Issues and PRs related to the benchmark subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL