benchmark: remove modules that require intl - #35968
Closed
richardlau wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
`inspector` and `trace_events` will throw errors if Node.js has been compiled with `--without-intl`. Refs: nodejs#35816
Copy link
Copy Markdown
Member
Author
|
CI is currently broken so I suggest we either fast track this or revert #35816. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Nov 4, 2020
aduh95
approved these changes
Nov 4, 2020
gireeshpunathil
approved these changes
Nov 5, 2020
HarshithaKP
approved these changes
Nov 5, 2020
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35968 ✔ Done loading data for nodejs/node/pull/35968 ----------------------------------- PR info ------------------------------------ Title benchmark: remove modules that require intl (#35968) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch richardlau:benchmark -> nodejs:master Labels author ready, benchmark Commits 1 - benchmark: remove modules that require intl Committers 1 - Richard Lau PR-URL: https://github.com/nodejs/node/pull/35968 Fixes: https://github.com/nodejs/node/issues/35962 Refs: https://github.com/nodejs/node/pull/35816 Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel Reviewed-By: Gireesh Punathil Reviewed-By: Harshitha K P ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35968 Fixes: https://github.com/nodejs/node/issues/35962 Refs: https://github.com/nodejs/node/pull/35816 Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel Reviewed-By: Gireesh Punathil Reviewed-By: Harshitha K P -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-11-04T19:59:57Z: https://ci.nodejs.org/job/node-test-pull-request/34068/ - Querying data for job/node-test-pull-request/34068/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Wed, 04 Nov 2020 19:50:59 GMT ✔ Approvals: 4 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35968#pullrequestreview-523701554 ✔ - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/35968#pullrequestreview-523791974 ✔ - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/35968#pullrequestreview-523865110 ✔ - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/35968#pullrequestreview-523916500 ✖ This PR needs to wait 38 more hours to land -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/346879770 |
Sorry, something went wrong.
Flarna
approved these changes
Nov 5, 2020
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 5, 2020
`inspector` and `trace_events` will throw errors if Node.js has been compiled with `--without-intl`. Refs: #35816 PR-URL: #35968 Fixes: #35962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
14 tasks
4 tasks
danielleadams
pushed a commit
that referenced
this pull request
Nov 9, 2020
`inspector` and `trace_events` will throw errors if Node.js has been compiled with `--without-intl`. Refs: #35816 PR-URL: #35968 Fixes: #35962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 9, 2020
`inspector` and `trace_events` will throw errors if Node.js has been compiled with `--without-intl`. Refs: #35816 PR-URL: #35968 Fixes: #35962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Closed
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
`inspector` and `trace_events` will throw errors if Node.js has been compiled with `--without-intl`. Refs: #35816 PR-URL: #35968 Fixes: #35962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
`inspector` and `trace_events` will throw errors if Node.js has been compiled with `--without-intl`. Refs: #35816 PR-URL: #35968 Fixes: #35962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inspector and trace_events will throw errors if Node.js has been
compiled with --without-intl.
Fixes: #35962
Refs: #35816
Checklist