FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: do not run GitHub actions for draft PRs by targos · Pull Request #35910 · nodejs/node · GitHub

/ node Public

build: do not run GitHub actions for draft PRs - #35910

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:no-draft-workflow
ConversationCommits (1)ChecksFiles changed
Closed

build: do not run GitHub actions for draft PRs#35910
targos wants to merge 1 commit into
nodejs:masterfrom
targos:no-draft-workflow

Conversation

targos commented Nov 1, 2020

Copy link
Copy Markdown
Member

Closes: #35899

I also pushed another branch just to verify that this doesn't prevent branch pushes to execute the workflow: https://github.com/nodejs/node/commits/no-draft-workflow-with-branch

Opened as a draft this time.

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 1, 2020

targos commented Nov 1, 2020

Copy link
Copy Markdown
Member Author

So, the condition works. Jobs were skipped:

targos marked this pull request as ready for review November 1, 2020 09:38

targos commented Nov 1, 2020

Copy link
Copy Markdown
Member Author

Marking the PR a s ready is not enough to re-run the workflows.

targos commented Nov 1, 2020

Copy link
Copy Markdown
Member Author

Apparently GitHub thinks I'm from the future 😄

gengjiawen commented Nov 1, 2020

Copy link
Copy Markdown
Member

When we mark it as ready, will it trigger github action run ?

Trott commented Nov 1, 2020

Copy link
Copy Markdown
Member

When we mark it as ready, will it trigger github action run ?

No, but I think we can manually run the jobs (and GitHub Actions are advisory in most cases anyway), so I'm OK with this behavior.

I'm going to try to manually kick off the jobs to confirm that's possible. Hopefully I'm not messing up @targos's experiment....

Trott commented Nov 1, 2020

Copy link
Copy Markdown
Member

When we mark it as ready, will it trigger github action run ?

No, but I think we can manually run the jobs (and GitHub Actions are advisory in most cases anyway), so I'm OK with this behavior.

I'm going to try to manually kick off the jobs to confirm that's possible. Hopefully I'm not messing up @targos's experiment....

Argh, nope, it skips them still. I guess we'd have to kick off Jenkins for any PR opened as Draft? I'm still OK with that, although there are jobs in GitHub Actions (ASAN, tarball building, coverage, codeowners assignment, maybe others) that don't get run in Jenkins..... so it's less ideal, for sure....

Trott commented Nov 1, 2020

Copy link
Copy Markdown
Member

Apparently GitHub thinks I'm from the future 😄

Hmmm... just in case the not-able-to-run-once-out-of-draft-mode stuff is all due to some daylight-savings-in-North-America weirdness, I'm going to put it into Draft mode again, and then take it out again....

Trott marked this pull request as draft November 1, 2020 14:48
Trott marked this pull request as ready for review November 1, 2020 14:49

Trott commented Nov 1, 2020

Copy link
Copy Markdown
Member

Maybe pushing (or force-pushing) will be enough to kick off the jobs?

Trott commented Nov 1, 2020

Copy link
Copy Markdown
Member

Rebasing against master and force-pushing to see if that kicks off the jobs.

Trott force-pushed the no-draft-workflow branch from 7c7ec67 to ac10fb9 Compare November 1, 2020 14:53

Trott commented Nov 1, 2020

Copy link
Copy Markdown
Member

That seems to have worked. I can live with that.

gengjiawen commented Nov 1, 2020

Copy link
Copy Markdown
Member

That seems to have worked. I can live with that.

Works with me too. Can this be integrated with our CI robot ?

jasnell commented Dec 16, 2020

Copy link
Copy Markdown
Member

Needs a rebase before this can land

targos added a commit that referenced this pull request Dec 21, 2020
build: do not run GitHub actions for draft PRs
aadb0bd 
PR-URL: #35910
Fixes: #35899
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

targos commented Dec 21, 2020

Copy link
Copy Markdown
Member Author

Landed in aadb0bd

targos closed this Dec 21, 2020
targos deleted the no-draft-workflow branch December 21, 2020 14:34
targos added a commit that referenced this pull request Dec 21, 2020
build: do not run GitHub actions for draft PRs
82a2626 
PR-URL: #35910
Fixes: #35899
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos mentioned this pull request Dec 22, 2020
Merged
richardlau mentioned this pull request Dec 23, 2020
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
benjamingr benjamingr approved these changes
lpinca lpinca approved these changes
watilde watilde approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Disable Github CI for draft PRs with label

9 participants

Back | FazBrowse Home | New Git URL