src: fix leading backslash bug in URL - #36613
Closed
RaisinTen wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Why are the tests skipped? 🤔 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Sorry, something went wrong.
RaisinTen
marked this pull request as ready for review
December 23, 2020 15:07
RaisinTen
force-pushed
the
src/fix-url-bug
branch
from
bae7d8a to
d1106fd
Compare
December 24, 2020 16:27
The associated condition mentioned in the URL parsing algorithm of the WHATWG URL Standard is: url is special and c is U+005C (\) So, `special_back_slash` must be updated whenever `special` is updated. Fixes: nodejs#36559
RaisinTen
force-pushed
the
src/fix-url-bug
branch
from
d92483a to
20a4a87
Compare
December 25, 2020 14:28
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
cc @nodejs/url |
Sorry, something went wrong.
Trott
approved these changes
Dec 27, 2020
watilde
approved these changes
Dec 28, 2020
jasnell
approved these changes
Dec 31, 2020
jasnell
pushed a commit
that referenced
this pull request
Dec 31, 2020
The associated condition mentioned in the URL parsing algorithm of the WHATWG URL Standard is: url is special and c is U+005C (\) So, `special_back_slash` must be updated whenever `special` is updated. Fixes: #36559 PR-URL: #36613 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
The associated condition mentioned in the URL parsing algorithm of the WHATWG URL Standard is: url is special and c is U+005C (\) So, `special_back_slash` must be updated whenever `special` is updated. Fixes: #36559 PR-URL: #36613 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
The associated condition mentioned in the URL parsing algorithm of the WHATWG URL Standard is: url is special and c is U+005C (\) So, `special_back_slash` must be updated whenever `special` is updated. Fixes: #36559 PR-URL: #36613 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Copy link
Copy Markdown
Contributor
|
Shouldn't this PR be semver-minor, @richardlau? It caused a somewhat breaking change (see #38963). Or do we have different rules relating to breaking changes when the change is a bug fix? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
It's only breaking if code is relying on the old incorrect behaviour. |
Sorry, something went wrong.
TimothyGu
reviewed
Jun 8, 2021
Comment thread
test/cctest/test_url.cc
| EXPECT_EQ(simple.protocol(), "http:"); | ||
| EXPECT_EQ(simple.host(), "x"); | ||
| } | ||
|
|
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
In the future, we should always add WPTs for bug fixes to the WHATWG URL parser, so that other implementations (e.g., browsers) can similarly benefit. I've upstreamed two of these tests in web-platform-tests/wpt#29271.
/cc @joyeecheung
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The associated condition mentioned in the URL parsing algorithm of the
WHATWG URL Standard is:
url is special and c is U+005C (\)
So, special_back_slash must be updated whenever special is updated.
Fixes: #36559
Checklist