FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: patches npm 6.14.11 by ruyadorno · Pull Request #37173 · nodejs/node · GitHub

/ node Public

deps: patches npm 6.14.11 - #37173

Closed
ruyadorno wants to merge 1 commit into
nodejs:v14.x-stagingfrom
npm:npm-6.14.11-patch
Closed

deps: patches npm 6.14.11#37173
ruyadorno wants to merge 1 commit into
nodejs:v14.x-stagingfrom
npm:npm-6.14.11-patch

Conversation

Copy link
Copy Markdown
Member

Patches the update to npm@6.14.11 that was missing some of the file updates.

Original changelog:

6.14.11 (2021-01-07)

DEPENDENCIES

DOCUMENTATION

TESTING

cc @BethGriggs

nodejs-github-bot added npm Issues and PRs related to the npm client dependency or the npm registry. v14.x labels Feb 1, 2021

Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Feb 2, 2021
edited by BethGriggs
Loading

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

CI ✅ .

I noticed that #37107 had 160 files changed, this PR has 159 files changed, and #36838 had 157.

I would appreciate a review/approval from @nodejs/npm (just to confirm)

ruyadorno commented Feb 2, 2021
edited
Loading

Copy link
Copy Markdown
Member Author

@BethGriggs 👍 it does LGTM

The missing file between this PR and #37107 seems to be deps/npm/node_modules/json-schema/draft-03/examples/calendar which is but an example file within the transitive dependency, that said I'm not sure why it was included at first and not now. 🤔

#36838 was missing a couple of files (which is the reason why we need to patch this now) so that's expected 😄

Copy link
Copy Markdown
Member

Thank you @ruyadorno

I think it'd still be preferable for an explicit review/approval from @nodejs/npm before landing

BethGriggs added the review wanted PRs that need reviews. label Feb 3, 2021

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

BethGriggs removed the review wanted PRs that need reviews. label Feb 3, 2021
BethGriggs pushed a commit that referenced this pull request Feb 4, 2021
PR-URL: #37173
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>

Copy link
Copy Markdown
Member

Landed in 408c7a6 (v14.x-staging)

BethGriggs closed this Feb 4, 2021
richardlau pushed a commit that referenced this pull request Feb 5, 2021
PR-URL: #37173
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
BethGriggs added a commit that referenced this pull request Feb 5, 2021
Notable changes:

- **deps**: upgrade npm to 6.14.11 (Ruy Adorno)
  (#37173)
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
  (#36618)

PR-URL: #37074
BethGriggs mentioned this pull request Feb 5, 2021
richardlau mentioned this pull request Feb 5, 2021
BethGriggs added a commit that referenced this pull request Feb 8, 2021
Notable changes:

- **deps**:
  - upgrade npm to 6.14.11 (Ruy Adorno)
    (#37173)
  - V8: backport dfcf1e86fac0 (Michaël Zasso)
    (#37245)
    - Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
  (#36618)

PR-URL: #37074
richardlau pushed a commit to richardlau/node-1 that referenced this pull request Feb 8, 2021
PR-URL: nodejs#37173
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
BethGriggs added a commit that referenced this pull request Feb 8, 2021
Notable changes:

- **deps**:
  - upgrade npm to 6.14.11 (Ruy Adorno)
    (#37173)
  - V8: backport dfcf1e86fac0 (Michaël Zasso)
    (#37245)
    - Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
  (#36618)

PR-URL: #37074
ruyadorno added a commit that referenced this pull request Feb 8, 2021
PR-URL: #37173
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
ruyadorno added a commit that referenced this pull request Feb 9, 2021
Notable changes:

* deps:
  * V8: backport dfcf1e86fac0 (Michaël Zasso) [#37245](#37245)
  * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)
ruyadorno added a commit that referenced this pull request Feb 9, 2021
Notable changes:

* deps:
  * V8: backport dfcf1e86fac0 (Michaël Zasso) [#37245](#37245)
  * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)
ruyadorno mentioned this pull request Feb 9, 2021
ruyadorno added a commit that referenced this pull request Feb 9, 2021
Notable changes:

* deps:
  * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)
  * V8: backport dfcf1e86fac0 (Michaël Zasso) [#37245](#37245)
    * Note: Node.js is not believed to be vulnerable to CVE-2021-21148.

PR-URL: #37286
richardlau pushed a commit that referenced this pull request Feb 9, 2021
PR-URL: #37173
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>

Backport-PR-URL: #37278

Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
BethGriggs added a commit that referenced this pull request Feb 9, 2021
Notable changes:

- **deps**:
  - upgrade npm to 6.14.11 (Ruy Adorno)
    (#37173)
  - V8: backport dfcf1e86fac0 (Michaël Zasso)
    (#37245)
    - Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
  (#36618)

PR-URL: #37074
ruyadorno added a commit that referenced this pull request Feb 10, 2021
Notable changes:

* deps:
  * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)

PR-URL: #37286
ruyadorno added a commit that referenced this pull request Feb 10, 2021
Notable changes:

* deps:
  * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)

PR-URL: #37286
wraithgar deleted the npm-6.14.11-patch branch June 26, 2025 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL