FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

v10.23.3 proposal by richardlau · Pull Request #37241 · nodejs/node · GitHub

/ node Public

v10.23.3 proposal - #37241

Merged
richardlau merged 5 commits into
v10.xfrom
v10.23.3-proposal
Feb 9, 2021
ConversationCommits (5)ChecksFiles changed
Merged

v10.23.3 proposal#37241
richardlau merged 5 commits into
v10.xfrom
v10.23.3-proposal

Conversation

richardlau commented Feb 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

2021-02-08, Version 10.23.3 'Dubnium' (LTS), @richardlau

Notable changes

The update to npm 6.14.11 has been relanded so that npm correctly reports its version.

Commits

nodejs-github-bot added meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. v10.x labels Feb 5, 2021
richardlau added a commit that referenced this pull request Feb 5, 2021
2021-02-08, Version 10.23.3 'Dubnium' (LTS)
61174d5 
Notable changes:

The update to npm 6.14.11 has been relanded so that npm correctly reports its version.

PR-URL: #37241

nodejs-github-bot commented Feb 5, 2021 •
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35971/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3731/ (✔️)

nodejs-github-bot commented Feb 7, 2021 •
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35996/ (✔️)
CITGM: https://ci.nodejs.org/job/citgm-smoker/2620
CITGM v10.x: https://ci.nodejs.org/job/citgm-smoker/2618/

tniessen and others added 2 commits February 8, 2021 15:38
crypto: fix crash when calling digest after piping
953a850 
When piping data into an SHA3 hash, EVP_DigestFinal_ex is called in
hash._flush, bypassing safeguards in the JavaScript layer. Calling
hash.digest causes EVP_DigestFinal_ex to be called again, resulting
in a segmentation fault in the SHA3 implementation of OpenSSL.

A relatively easy solution is to cache the result of calling
EVP_DigestFinal_ex until the Hash object is garbage collected.

PR-URL: #28251
Fixes: #28245
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Backport-PR-URL: #37009
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
test: add test that verifies crypto stream pipeline
1c6fbd6 
This test fails prior to 990feaf being cherry-picked
due to stream.pipeline with a crypto.Hash not working properly.

That bug also seems to have affected md5.

PR-URL: #37009
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>

richardlau commented Feb 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

@BethGriggs has raised some questions around the commit metadata (or lack thereof) for the revert commit. I'll open a PR to do the revert and npm reland.
Edit: #37278

ruyadorno approved these changes Feb 9, 2021
View reviewed changes

ruyadorno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

needs to update the dates, all the rest LGTM 👍

richardlau and others added 3 commits February 9, 2021 10:57
Revert "deps: upgrade npm to 6.14.11"
7b7fb43 
This reverts commit cc6b695.

PR-URL: #37278
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
deps: upgrade npm to 6.14.11
fe2c980 
PR-URL: #37173
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>

Backport-PR-URL: #37278

Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
2021-02-09, Version 10.23.3 'Dubnium' (LTS)
ef1c506 
Notable changes:

The update to npm 6.14.11 has been relanded so that npm correctly reports its version.

PR-URL: #37241

nodejs-github-bot commented Feb 9, 2021 •
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36043/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3749/ (✔️)

richardlau commented Feb 9, 2021

Copy link
Copy Markdown
Member Author

needs to update the dates, all the rest LGTM 👍

Date has been updated to today and commits rebased to accommodate #37278. If the CI's come back green I'll attempt to get this out today otherwise it'll slip to tomorrow (and I'll have to adjust the dates again).

nodejs-github-bot commented Feb 9, 2021 •
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36047/ (✔️)
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3749/ (✔️)
CITGM: https://ci.nodejs.org/job/citgm-smoker/2625/
CITGM (v10.x): https://ci.nodejs.org/job/citgm-smoker/2618/

Release CI on ef1c506: https://ci-release.nodejs.org/job/iojs+release/6656/

richardlau requested a review from BethGriggs February 9, 2021 18:07
richardlau added a commit that referenced this pull request Feb 9, 2021
Working on v10.23.4
f95cb44 
PR-URL: #37241
richardlau merged commit ef1c506 into v10.x Feb 9, 2021
richardlau deleted the v10.23.3-proposal branch February 9, 2021 23:00
richardlau added a commit that referenced this pull request Feb 9, 2021
2021-02-09, Version 10.23.3 'Dubnium' (LTS)
857fbdb 
Notable changes:

The update to npm 6.14.11 has been relanded so that npm correctly reports its version.

PR-URL: #37241
richardlau mentioned this pull request Feb 9, 2021
Merged
richardlau added a commit to richardlau/nodejs.org that referenced this pull request Feb 9, 2021
Blog: v10.23.3 release post
cd53509 
Refs: nodejs/node#37241
richardlau added a commit to nodejs/nodejs.org that referenced this pull request Feb 9, 2021
Blog: v10.23.3 release post (#3673)
f14dfaf 
Refs: nodejs/node#37241
targos added the release Issues and PRs related to Node.js releases. label Apr 11, 2021
targos removed npm Issues and PRs related to the npm client dependency or the npm registry. meta Issues and PRs related to the general management of the project. labels Jun 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ruyadorno ruyadorno approved these changes
BethGriggs Awaiting requested review from BethGriggs

Assignees

No one assigned

Labels

release Issues and PRs related to Node.js releases.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL