[v14.x backport] fs: improve fsPromises readFile performance - #37703
Closed
Linkgoron wants to merge 1 commit into
Closed
[v14.x backport] fs: improve fsPromises readFile performance#37703Linkgoron wants to merge 1 commit into
Linkgoron wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Linkgoron
force-pushed
the
backport-37608-to-v14.x
branch
from
fd69e7b to
afd0b68
Compare
March 10, 2021 23:57
Copy link
Copy Markdown
Contributor
Author
|
Benchmark numbers: confidence improvement accuracy (*) (**) (***) fs/readfile-promises.js concurrent=1 len=1024 duration=5 *** 24.56 % ±0.52% ±0.69% ±0.90% fs/readfile-promises.js concurrent=1 len=16777216 duration=5 *** 353.44 % ±4.88% ±6.56% ±8.68% fs/readfile-promises.js concurrent=10 len=1024 duration=5 *** 30.64 % ±0.58% ±0.78% ±1.02% fs/readfile-promises.js concurrent=10 len=16777216 duration=5 *** 573.13 % ±4.38% ±5.89% ±7.78% |
Sorry, something went wrong.
Linkgoron
force-pushed
the
backport-37608-to-v14.x
branch
from
afd0b68 to
1d81990
Compare
March 11, 2021 00:58
Copy link
Copy Markdown
Contributor
Author
|
Noticed that this needs to wait for two weeks. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
MylesBorins
force-pushed
the
v14.x-staging
branch
from
11505ad to
6b115d7
Compare
April 6, 2021 19:54
Improve the fsPromises readFile performance by allocating only one buffer, when size is known, increase the size of the readbuffer chunks, and dont read more data if size bytes have been read refs: nodejs#37583 Backport-PR-URL: nodejs#37703 PR-URL: nodejs#37608
Linkgoron
force-pushed
the
backport-37608-to-v14.x
branch
from
1d81990 to
63c43b0
Compare
April 9, 2021 08:59
Copy link
Copy Markdown
Contributor
Author
|
@targos given the AbortController PR, this (the original PR) might land cleanly without any modifications after #35911 is backported. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This PR is actually what started my quest of backporting AbortController 😄 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the fsPromises readFile performance
by allocating only one buffer, when size is known,
increase the size of the readbuffer chunks,
and dont read more data if size bytes have been read
refs: #37583
PR-URL: #37608
I only cherry-picked the changes to fs/promises.js (first commit) but didn't backport the benchmark (second commit). If that's needed, I'll be happy to do it as well. This PR also incorporates the changes of #37127, so I'm not sure if that PR should be backported before this one.