[v14.x backport] fs: improve fsPromises readFile performance - #39838
Closed
MoritzLoewenstein wants to merge 2 commits into
Closed
[v14.x backport] fs: improve fsPromises readFile performance#39838MoritzLoewenstein wants to merge 2 commits into
MoritzLoewenstein wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Assuming upstream and origin are configured in a classical way, you should be able to cherry-pick the original commits using the following commands: git fetch upstream master git fetch upstream v14.x-staging git reset upstream/v14.x-staging --hard git cherry-pick 24fd791184ad0ba27f92ac49b820aec78e491296 git cherry-pick e216d8f4a1277e77903e9c2c716fefa3b196761b git cherry-pick b9fd4eb651dd26c3845aa46714593abae185455d git push origin HEAD:fs-read-promises-backport -f |
Sorry, something went wrong.
MoritzLoewenstein
force-pushed
the
fs-read-promises-backport
branch
from
b4fffb0 to
5d007af
Compare
August 21, 2021 20:41
Copy link
Copy Markdown
Author
|
Thank you :) Added ArrayPrototypePush import to 2nd commit, your third cherry-pick is already in v14. |
Sorry, something went wrong.
MoritzLoewenstein
force-pushed
the
fs-read-promises-backport
branch
2 times, most recently
from
71a3fb3 to
6f22200
Compare
August 21, 2021 21:52
Linkgoron
reviewed
Aug 25, 2021
Comment thread
lib/internal/fs/promises.js
Outdated
MoritzLoewenstein
force-pushed
the
fs-read-promises-backport
branch
from
81f457d to
a179bd3
Compare
August 25, 2021 21:35
MylesBorins
force-pushed
the
v14.x-staging
branch
from
b3f51ee to
327838d
Compare
August 31, 2021 14:58
Refs: nodejs#38004 (comment) PR-URL: nodejs#38061 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Improve the fsPromises readFile performance by allocating only one buffer, when size is known, increase the size of the readbuffer chunks, and dont read more data if size bytes have been read Refs: nodejs#37583 PR-URL: nodejs#37608 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MoritzLoewenstein
force-pushed
the
fs-read-promises-backport
branch
from
a179bd3 to
2ffa9c5
Compare
September 1, 2021 07:30
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Refs: #38004 (comment) PR-URL: #38061 Backport-PR-URL: #39838 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Improve the fsPromises readFile performance by allocating only one buffer, when size is known, increase the size of the readbuffer chunks, and dont read more data if size bytes have been read Refs: #37583 PR-URL: #37608 Backport-PR-URL: #39838 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
approved these changes
Sep 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the fsPromises readFile performance
by allocating only one buffer, when size is known,
increase the size of the readbuffer chunks,
and dont read more data if size bytes have been read.
Also moves constants to internal/fs/utils.
refs: #37583
(Old) Backport-PR-URL: #37703
PR-URL: #37608
This PR is backporting the fs readFile promise performance improvements to v14.x, essentially copying these two prs (i wasnt able to cherry-pick, not sure if its my git skills or something else):
#38061 "fs: move constants to internal/fs/utils.js"
#37703 "[v14.x backport] fs: improve fsPromises readFile performance"