FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add known_issues test for #13683 by Trott · Pull Request #37744 · nodejs/node · GitHub

/ node Public

test: add known_issues test for #13683 - #37744

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:test-for-13683
Mar 18, 2021
Merged

test: add known_issues test for #13683#37744
Trott merged 1 commit into
nodejs:masterfrom
Trott:test-for-13683

Conversation

Trott commented Mar 13, 2021

Copy link
Copy Markdown
Member

Add a known_issues test for a known Windows issue.

Refs: #13683

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 13, 2021

This comment has been minimized.

Copy link
Copy Markdown
Member

You may need to add a section and skip for IBM i.

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Mar 13, 2021
edited by Trott
Loading

Copy link
Copy Markdown
Collaborator

Trott commented Mar 14, 2021

Copy link
Copy Markdown
Member Author

According to the docs:

The path.relative() method returns the relative path from from to to based on the current working directory.

So you'll get different results depending on where you are in the file system.

> process.cwd()
'/'
> path.posix.relative('a/b/c', '../../x');
'../../../x'
> process.chdir('/Users/trott/io.js')
undefined
> process.cwd()
'/Users/trott/io.js'
> path.posix.relative('a/b/c', '../../x');
'../../../../../x'
> 

So I updated the test to use a regex to make sure we cover all (three) possibilities.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Mar 14, 2021
edited by Trott
Loading

Copy link
Copy Markdown
Collaborator

Add a known_issues test for a known Windows issue.

Refs: nodejs#13683

PR-URL: nodejs#37744
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

Trott commented Mar 18, 2021

Copy link
Copy Markdown
Member Author

Landed in 55f0955

Trott merged commit 55f0955 into nodejs:master Mar 18, 2021
Trott deleted the test-for-13683 branch March 18, 2021 04:58
ruyadorno pushed a commit that referenced this pull request Mar 20, 2021
Add a known_issues test for a known Windows issue.

Refs: #13683

PR-URL: #37744
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
ruyadorno mentioned this pull request Mar 30, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Add a known_issues test for a known Windows issue.

Refs: #13683

PR-URL: #37744
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams mentioned this pull request May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL