FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

path: fix posix.relative() on Windows by Trott · Pull Request #37747 · nodejs/node · GitHub

/ node Public

path: fix posix.relative() on Windows - #37747

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:fix-for-13683
Apr 3, 2021
ConversationCommits (1)ChecksFiles changed
Merged

path: fix posix.relative() on Windows#37747
Trott merged 1 commit into
nodejs:masterfrom
Trott:fix-for-13683

Conversation

Trott commented Mar 14, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

First commit is #37744. Second commit will be rebased to be the only commit in this PR once that other pull request lands.

Fixes: #13683

nodejs-github-bot added needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem. labels Mar 14, 2021

This comment has been minimized.

Sign in to view
Trott marked this pull request as draft March 14, 2021 03:04

This comment has been minimized.

Sign in to view
Trott marked this pull request as ready for review March 14, 2021 03:57

This comment has been minimized.

Sign in to view
Trott marked this pull request as draft March 14, 2021 04:41
Trott marked this pull request as ready for review March 14, 2021 05:03

This comment has been minimized.

Sign in to view

Trott commented Mar 14, 2021

Copy link
Copy Markdown
Member Author

The change to test-path-resolve is, in my opinion, a bugfix and not a semver-major change. In all other cases, calling path.posix.resolve() returns a POSIX-y path. In these two (really one) edge cases in the test, it results in a Windows-y path on Windows and a POSIX-y path elsewhere. I think path.posix.resolve() should always return a POSIX-y path and the fact that it doesn't in some cases is surprising and a bug.

Trott commented Mar 14, 2021

Copy link
Copy Markdown
Member Author

@nodejs/path @nodejs/platform-windows

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
aduh95 reviewed Mar 14, 2021
View reviewed changes
Comment thread lib/path.js Outdated
Comment thread lib/path.js Outdated

This comment has been minimized.

Sign in to view
Trott mentioned this pull request Mar 15, 2021
Closed

Trott commented Mar 18, 2021

Copy link
Copy Markdown
Member Author

@nodejs/path @nodejs/platform-windows @nodejs/tsc This could use some reviews.

This comment has been minimized.

Sign in to view
mcollina requested changes Mar 18, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good minus one nit.

Comment thread lib/path.js Outdated

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
targos reviewed Mar 19, 2021
View reviewed changes
Comment thread test/parallel/test-path-resolve.js Outdated

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Mar 19, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36803/

Trott requested a review from mcollina March 22, 2021 13:52

Trott commented Mar 26, 2021

Copy link
Copy Markdown
Member Author

@mcollina I believe your request for changes has been addressed. Can you take a look?

mcollina approved these changes Apr 2, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

path: fix posix.relative() on Windows
b0d5e03 
Fixes: nodejs#13683

PR-URL: nodejs#37747
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Trott commented Apr 3, 2021

Copy link
Copy Markdown
Member Author

Landed in b0d5e03

Trott merged commit b0d5e03 into nodejs:master Apr 3, 2021
Trott deleted the fix-for-13683 branch April 3, 2021 02:31
MylesBorins pushed a commit that referenced this pull request Apr 4, 2021
path: fix posix.relative() on Windows
de67952 
Fixes: #13683

PR-URL: #37747
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins mentioned this pull request Apr 4, 2021
Merged
BethGriggs mentioned this pull request Apr 12, 2021
Merged
JustSlone mentioned this pull request Nov 5, 2022
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 left review comments
mcollina mcollina approved these changes
+1 more reviewer
targos targos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

path.posix.relative returns different results for *nix and Windows versions of node

5 participants

Back | FazBrowse Home | New Git URL