lib: include url in bootstrap snapshot and remove unnecessary lazy-loads - #38826
Closed
joyeecheung wants to merge 1 commit into
Closed
lib: include url in bootstrap snapshot and remove unnecessary lazy-loads#38826joyeecheung wants to merge 1 commit into
joyeecheung wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
May 27, 2021
targos
approved these changes
May 27, 2021
Apakottur
approved these changes
May 27, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
It seems some tests fail with this, some tmp files weren't properly cleaned up after the test finished. Can't clean tmpdir: /home/iojs/tmp/.tmp.261
Files blocking: [ '.nfs00000000019201330000031d' ]
Note: ".nfs*" might be files that were open and unlinked but not closed.
See http://nfs.sourceforge.net/#faq_d2 for details.
/home/iojs/build/workspace/node-test-binary-arm/test/common/tmpdir.js:55
throw e;
^
Error: ENOTEMPTY: directory not empty, rmdir '/home/iojs/tmp/.tmp.261'
at Object.rmdirSync (node:fs:1157:10)
at _rmdirSync (node:internal/fs/rimraf:260:21)
at rimrafSync (node:internal/fs/rimraf:193:7)
at Object.rmSync (node:fs:1204:10)
at rmSync (/home/iojs/build/workspace/node-test-binary-arm/test/common/tmpdir.js:9:6)
at process.onexit (/home/iojs/build/workspace/node-test-binary-arm/test/common/tmpdir.js:40:5)
at process.emit (node:events:406:35) {
errno: -39,
syscall: 'rmdir',
code: 'ENOTEMPTY',
path: '/home/iojs/tmp/.tmp.261'
}
I can't see why this PR would result in a difference, is it a test util bug? @nodejs/testing |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
XadillaX
approved these changes
Jun 2, 2021
Copy link
Copy Markdown
Member
|
This doesn't land cleanly on v14.x-staging. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #35711