FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: compose with async functions by ronag · Pull Request #39435 · nodejs/node · GitHub

/ node Public

stream: compose with async functions - #39435

Closed
ronag wants to merge 3 commits into
nodejs:masterfrom
nxtedition:async-compose
ConversationCommits (3)ChecksFiles changed
Closed

stream: compose with async functions#39435
ronag wants to merge 3 commits into
nodejs:masterfrom
nxtedition:async-compose

Conversation

ronag commented Jul 19, 2021

Copy link
Copy Markdown
Member

Enables async function support for stream.compose.

stream: compose with async functions
f8e9aac 
Enables async function support for stream.compose.
ronag added the stream Issues and PRs related to the stream subsystem. label Jul 19, 2021
ronag requested a review from benjamingr July 19, 2021 06:20
nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 19, 2021

ronag commented Jul 19, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

We disabled async function in the compose PR due to @benjamingr request to review the async fn API before landing.

VoltrexKeyva reviewed Jul 19, 2021
View reviewed changes
Comment thread doc/api/stream.md Outdated
VoltrexKeyva reviewed Jul 19, 2021
View reviewed changes
Comment thread doc/api/stream.md Outdated
ronag and others added 2 commits July 19, 2021 12:09
Update doc/api/stream.md
ae8fe56 
Co-authored-by: Voltrex <mohammadkeyvanzade94@gmail.com>
Update doc/api/stream.md
ed7142b 
Co-authored-by: Voltrex <mohammadkeyvanzade94@gmail.com>

ronag commented Jul 19, 2021

Copy link
Copy Markdown
Member Author

@nodejs/streams

VoltrexKeyva reviewed Jul 19, 2021
View reviewed changes
Comment thread doc/api/stream.md

jasnell commented Jul 19, 2021

Copy link
Copy Markdown
Member

Changes look good but does this need additional tests?

ronag commented Jul 19, 2021

Copy link
Copy Markdown
Member Author

Changes look good but does this need additional tests?

The tests are already merged through the original PR.

mcollina approved these changes Jul 19, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

nodejs-github-bot commented Jul 20, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39160/

ronag added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jul 20, 2021

nodejs-github-bot commented Jul 21, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39196/

nodejs-github-bot commented Jul 21, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39200/

ronag commented Jul 21, 2021

Copy link
Copy Markdown
Member Author

Landed in 48ff0a1

ronag closed this Jul 21, 2021
ronag added a commit that referenced this pull request Jul 21, 2021
stream: compose with async functions
48ff0a1 
Enables async function support for stream.compose.

PR-URL: #39435
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos commented Jul 21, 2021

Copy link
Copy Markdown
Member

Depends on #39029

ronag commented Jul 28, 2021

Copy link
Copy Markdown
Member Author

#39563

targos mentioned this pull request Aug 24, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
benjamingr benjamingr approved these changes
+1 more reviewer
VoltrexKeyva VoltrexKeyva left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL