FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v16.x backport] stream: add stream.compose by ronag · Pull Request #39563 · nodejs/node · GitHub

/ node Public

[v16.x backport] stream: add stream.compose - #39563

Closed
ronag wants to merge 7 commits into
nodejs:v16.x-stagingfrom
nxtedition:backport-39029-to-v16.x
ConversationCommits (7)ChecksFiles changed
Closed

[v16.x backport] stream: add stream.compose#39563
ronag wants to merge 7 commits into
nodejs:v16.x-stagingfrom
nxtedition:backport-39029-to-v16.x

Conversation

ronag commented Jul 28, 2021

Copy link
Copy Markdown
Member

No description provided.

ronag changed the base branch from master to v16.x-staging July 28, 2021 12:32
nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels Jul 28, 2021
ronag force-pushed the backport-39029-to-v16.x branch from fb7bee4 to a94a29c Compare July 28, 2021 12:32
ronag mentioned this pull request Jul 28, 2021
Closed

ronag commented Jul 28, 2021

Copy link
Copy Markdown
Member Author

@nodejs/streams

This was referenced Jul 28, 2021
Closed
Closed
ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2021

nodejs-github-bot commented Jul 28, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39314/

mcollina approved these changes Jul 28, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jul 29, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2021

nodejs-github-bot commented Jul 29, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39329/

nodejs-github-bot commented Jul 29, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39331/

bricss mentioned this pull request Jul 29, 2021
Merged
ronag force-pushed the backport-39029-to-v16.x branch from c55be7d to 99e2820 Compare July 29, 2021 13:50
ronag force-pushed the backport-39029-to-v16.x branch from 99e2820 to 2722246 Compare July 29, 2021 13:51

targos commented Aug 1, 2021

Copy link
Copy Markdown
Member

Can you please rebase (a commit was removed from staging)?

targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 1, 2021
ronag force-pushed the backport-39029-to-v16.x branch 2 times, most recently from 1d2ffc6 to 1314e35 Compare August 23, 2021 13:54
ronag marked this pull request as ready for review August 23, 2021 13:56
ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2021
stream: add stream.compose
7663895 
Refs: nodejs#32020

PR-URL: nodejs#39029
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Backport-PR-URL: nodejs#39563
ronag force-pushed the backport-39029-to-v16.x branch from 1314e35 to 7663895 Compare August 23, 2021 13:58
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2021

nodejs-github-bot commented Aug 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39644/

ronag requested a review from targos August 23, 2021 14:11

nodejs-github-bot commented Aug 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39645/

ronag removed the blocked PRs that are blocked by other issues or PRs. label Aug 23, 2021

nodejs-github-bot commented Aug 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39648/

targos commented Aug 23, 2021

Copy link
Copy Markdown
Member

test-stream-compose.js is failing again

ronag requested a review from mcollina August 24, 2021 13:01

ronag commented Aug 24, 2021

Copy link
Copy Markdown
Member Author

This need a few more things to make it pass.

nodejs-github-bot commented Aug 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39655/

ronag mentioned this pull request Aug 24, 2021
Closed

ronag commented Aug 24, 2021

Copy link
Copy Markdown
Member Author

@nodejs/streams this needs an extra eye since it's not a straightforward backport.

targos commented Aug 24, 2021

Copy link
Copy Markdown
Member

To the reviewers: note that this also contains the changes from #39435 and #39494

ronag commented Aug 24, 2021

Copy link
Copy Markdown
Member Author

Also some changes from #39294

nodejs-github-bot commented Aug 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39656/

targos pushed a commit that referenced this pull request Sep 6, 2021
stream: add stream.compose
cb44781 
Refs: #32020

PR-URL: #39029
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Backport-PR-URL: #39563

targos commented Sep 6, 2021

Copy link
Copy Markdown
Member

Landed in cb44781

targos closed this Sep 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
targos Awaiting requested review from targos
mcollina Awaiting requested review from mcollina

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. semver-minor PRs that contain new features and should be released in the next minor version. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL