stream: mark compose as experimental - #39494
Closed
ronag wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@nodejs/streams |
Sorry, something went wrong.
targos
approved these changes
Jul 23, 2021
benjamingr
approved these changes
Jul 23, 2021
mcollina
approved these changes
Jul 23, 2021
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Jul 23, 2021
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/39494 ✔ Done loading data for nodejs/node/pull/39494 ----------------------------------- PR info ------------------------------------ Title stream: mark compose as experimental (#39494) Author Robert Nagy (@ronag) Branch ronag:compose-experimental -> nodejs:master Labels author ready, doc, stream Commits 1 - stream: mark compose as experimental Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/39494 Reviewed-By: Michaël Zasso Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/39494 Reviewed-By: Michaël Zasso Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 23 Jul 2021 05:47:16 GMT ✔ Approvals: 4 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/39494#pullrequestreview-713414599 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/39494#pullrequestreview-713422146 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/39494#pullrequestreview-713432290 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/39494#pullrequestreview-713862106 ✖ This PR needs to wait 17 more hours to land ✔ Last GitHub Actions successful ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1062446009 |
Sorry, something went wrong.
ronag
added a commit
that referenced
this pull request
Jul 25, 2021
PR-URL: #39494 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given #39483 it seems prudent to mark stream.compose as experimental for now.