benchmark: add constant declarations for net - #3950
Closed
JungMinu wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Could you fix the connections and server declarations too? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Can you add a 'use strict'; statement at the first line ? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@tflanagan @targos Sure, will do :) |
Sorry, something went wrong.
Constant declaration for `net` is omitted in `idle_server.js` Add a constant declaration for constant `net` benchmark: add constant declarations for `net`
Copy link
Copy Markdown
Member
Author
|
finished and rebased, Thanks :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM if you still want to land this. We should eventually include benchmark in ESLint. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
JungMinu
added a commit
that referenced
this pull request
Jan 29, 2016
Constant declaration for `net` is omitted in `idle_server.js` Add a constant declaration for constant `net` PR-URL: #3950 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
Constant declaration for `net` is omitted in `idle_server.js` Add a constant declaration for constant `net` PR-URL: #3950 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 17, 2016
Constant declaration for `net` is omitted in `idle_server.js` Add a constant declaration for constant `net` PR-URL: #3950 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
Constant declaration for `net` is omitted in `idle_server.js` Add a constant declaration for constant `net` PR-URL: #3950 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
Constant declaration for `net` is omitted in `idle_server.js` Add a constant declaration for constant `net` PR-URL: #3950 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Constant declaration for `net` is omitted in `idle_server.js` Add a constant declaration for constant `net` PR-URL: nodejs#3950 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constant declaration for net is omitted in idle_server.js
Add a constant declaration for constant net