Release proposal: v5.5.1 (Stable) - #5141
Conversation
Sorry, something went wrong.
PR-URL: #5057 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add links to `process.arch` and `process.platform`. PR-URL: #5006 Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
PR-URL: #4904 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io>
Sort links in lexical order PR-URL: #5076 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Enable `space-unary-ops` in `.eslintrc`. This prohibits things like:
i ++ // use `i++` instead
typeof(foo) // use `typeof foo` or `typeof (foo)` instead
Ref: #4772 (comment)
PR-URL: #5063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Add fromArrayLike() to handle logic of copying in values from array-like argument. PR-URL: #4948 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
There was a very subtle change in behavior introduced with 27def4f In the past if querystring.parse was given Infinity for maxKeys, everything worked as expected. Check to see is maxKeys is Infinity before forwarding the value to String.prototype.split which causes this regression PR-URL: #5066 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Currently a debug context is created for various calls to util. If the node debugger is being run the main context is the debug context. In this case node_contextify was freeing the debug context and causing everything to explode. This change moves around the logic and no longer frees the context. There is a concern about the dangling pointer The regression test was adapted from code submitted by @3y3 in #4815 Fixes: #4440 Fixes: #4815 Fixes: #4597 Fixes: #4952 PR-URL: #4815 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
A few tests have started failing on Raspberry Pi devices in CI. https://ci.nodejs.org/job/node-test-binary-arm/943/ PR-URL: #5082 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Ref: #4830 Ref: #3635 Ref: #4526
Remove stray square brackets from dgram documentation. PR-URL: #5114 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Prefer using Object.setPrototypeOf() instead. PR-URL: #5069 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
There is no guarantee UDP messages will be received. Accommodate the occasional dropped message. This is a functionality test, not a performance benchmark. Speed up the test by not sending 1500 messages across three ports. Fixes: #4526 PR-URL: #5125 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Enable linting rule to forbid empty character classes in regular expressions. See http://eslint.org/docs/rules/no-empty-character-class Organize "Possible Error" rules in .eslintrc in alphabetical order to match eslint documentation. PR-URL: #5115 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Notable changes:
|
924cc6c should be dropped, it won't compile. |
Sorry, something went wrong.
|
if #5109 can get done in time we should try to get it out asap |
Sorry, something went wrong.
|
citgm: https://ci.nodejs.org/job/thealphanerd-smoker/63/ Only failure is expected (eslint on ppc) ✅ |
Sorry, something went wrong.
|
Thanks for including 32ac3769f5. I'd say it warrants a notable change entry. |
Sorry, something went wrong.
|
@rvagg I think it is also worth considering npm@b5362b5 This has not yet landed on master due to the npm breakage, but I have run citgm on a patched branch and everything was a ok. the npm update includes a fix for the progress bar, which I think the community would greatly appreciate |
Sorry, something went wrong.
|
@bnoordhuis @seishun the commit list at the bottom of the OP are not included in this, both the Private V8 API and the http upgrade event. The former has since been correctly labelled as dont-land-on-v5.x and the latter I justified as:
We'll have a semver-minor release next week that will pull all of the outstanding changes into it, we just need to have this one at least seem lower risk for users. FWIW all the other lines are going to need releases soon as well, we have domains (and other) fixes queued up in 0.10 and 0.12 and v4.x has a big backlog that needs to be dealt with too. All 3 of those lines are being kept to the absolute minimum required for the security release. |
Sorry, something went wrong.
|
@thealphanerd at this stage I'm opting for not including #5097, it doesn't have any reviews and there's a risk the PR may be modified before landed on master so we'll just have to catch up on it in next week's release. |
Sorry, something went wrong.
5.6.0 was just shipped, does that mean those patch-level things will be in 5.6.1 next week? |
Sorry, something went wrong.
|
@silverwind ... yes, those will go in the next release cycle |
Sorry, something went wrong.
|
FYI: The docker-node images have been updated. We're just waiting for the pull request to be reviewed and merged: |
Sorry, something went wrong.
Sorry, something went wrong.
|
Yes, this was finished off in node-private and included commits that bumped it up to 5.6.0. Because this isn't LTS we didn't limit it to just the security commits so all of commits listed above, and a few more, made it in. There's not a whole lot waiting to land but next week will probably be a 5.7.0. |
Sorry, something went wrong.
Security release, to go out ~ Tuesday, the 9th of February, 11pm UTC with releases across all active lines as per https://groups.google.com/d/msg/nodejs-sec/G8IA0G4uA88/So3Cw84YDwAJ.
Pending additions being worked on by the security team. We'll get everything else ready here and finish it off in our private repo. Still needs "Notable items" filled out. Either myself or @jasnell will handle this release. I'm doing v0.10 and v0.12, @jasnell is doing v4 and was slated for v5 but we may switch that up depending our workloads finalising the security fixes.
Because this is not an LTS line this release is not restricted to security+build changes as we are doing with v0.10, v0.12 and v4. However, I've opted to keep semver-minor changes out of this so we can get away with a patch-level bump, see below for a list of changes left out. Unfortunately, because we haven't had a release in ~20 days the backlog is kind of large even with just semver-patch changes.
Changes (apparently) available for v5.6.0. Note that some of these are semver-patch but build on semver-minor changes so I've left them out so out-of-order cherry-picking doesn't leave us in an inconsistent state. #4337 was also left out because there's a remote possibility it could break for some users, but it's considered a fix rather than semver-major, see discussion there.
CI for this: https://ci.nodejs.org/job/node-test-commit/2148/ (green on all but arm where it's yellow)