FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add more details to process.env by evanlucas · Pull Request #4924 · nodejs/node · GitHub

/ node Public

doc: add more details to process.env - #4924

Merged
evanlucas merged 1 commit into
nodejs:masterfrom
evanlucas:nullenv
Jan 30, 2016
ConversationCommits (1)ChecksFiles changed
Merged

doc: add more details to process.env#4924
evanlucas merged 1 commit into
nodejs:masterfrom
evanlucas:nullenv

Conversation

evanlucas commented Jan 28, 2016

Copy link
Copy Markdown
Contributor

process.env has a few quirks that deserve documenting.

The commit documents:

  • How assigning to process.env will implicitly call toString()
  • How to remove an environment variable from process.env

/cc @cjihrig

evanlucas added the doc Issues and PRs related to the documentations. label Jan 28, 2016
cjihrig reviewed Jan 28, 2016
View reviewed changes
Comment thread doc/api/process.markdown Outdated

cjihrig Jan 28, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe just say "implicitly convert the value to a string"

cjihrig commented Jan 28, 2016

Copy link
Copy Markdown
Contributor

LGTM

mscdex added the process Issues and PRs related to the process subsystem. label Jan 28, 2016
evanlucas force-pushed the nullenv branch 2 times, most recently from 750d206 to d9d7aa9 Compare January 28, 2016 16:30

evanlucas commented Jan 28, 2016

Copy link
Copy Markdown
Contributor Author

Nits addressed

cjihrig commented Jan 28, 2016

Copy link
Copy Markdown
Contributor

LGTM

silverwind reviewed Jan 28, 2016
View reviewed changes
Comment thread doc/api/process.markdown

silverwind Jan 28, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe scrap that Example: and end the sentence above in a :?

evanlucas Jan 29, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm personally a fan of explicitly marking it as an example, but either way. It seems to be split pretty evenly in that file.

silverwind Jan 29, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, there's a few example markers already in that file, so I guess it's fine.

jasnell commented Jan 29, 2016

Copy link
Copy Markdown
Member

LGTM.
lts watch label applied

silverwind commented Jan 29, 2016

Copy link
Copy Markdown
Contributor

LGTM

doc: add more details to process.env
8ff9b56 
process.env has a few quirks that deserve documenting.

The commit documents:

- How assigning to process.env will implicitly call `toString()`
- How to remove an environment variable from process.env

PR-URL: nodejs#4924
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas closed this Jan 30, 2016
evanlucas deleted the nullenv branch January 30, 2016 04:09
evanlucas merged commit 8ff9b56 into nodejs:master Jan 30, 2016

evanlucas commented Jan 30, 2016

Copy link
Copy Markdown
Contributor Author

Landed in 8ff9b56. Thanks!

rvagg pushed a commit that referenced this pull request Feb 8, 2016
doc: add more details to process.env
396e4b9 
process.env has a few quirks that deserve documenting.

The commit documents:

- How assigning to process.env will implicitly call `toString()`
- How to remove an environment variable from process.env

PR-URL: #4924
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
doc: add more details to process.env
2bc27b3 
process.env has a few quirks that deserve documenting.

The commit documents:

- How assigning to process.env will implicitly call `toString()`
- How to remove an environment variable from process.env

PR-URL: #4924
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
doc: add more details to process.env
83efd0d 
process.env has a few quirks that deserve documenting.

The commit documents:

- How assigning to process.env will implicitly call `toString()`
- How to remove an environment variable from process.env

PR-URL: #4924
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
doc: add more details to process.env
1afa350 
process.env has a few quirks that deserve documenting.

The commit documents:

- How assigning to process.env will implicitly call `toString()`
- How to remove an environment variable from process.env

PR-URL: #4924
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL