FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix, remove unnecessary bind(this) by wKich · Pull Request #4797 · nodejs/node · GitHub

/ node Public

doc: fix, remove unnecessary bind(this) - #4797

Closed
wKich wants to merge 1 commit into
nodejs:masterfrom
wKich:patch-1
ConversationCommits (1)ChecksFiles changed
Closed

doc: fix, remove unnecessary bind(this)#4797
wKich wants to merge 1 commit into
nodejs:masterfrom
wKich:patch-1

Conversation

wKich commented Jan 21, 2016

Copy link
Copy Markdown
Contributor

No description provided.

benjamingr commented Jan 21, 2016

Copy link
Copy Markdown
Member

Might as well make it an expression (single-line) arrow function

benjamingr commented Jan 21, 2016

Copy link
Copy Markdown
Member

LGTM.

wKich commented Jan 21, 2016

Copy link
Copy Markdown
Contributor Author

I think will need to refactor all other arrow functions, If make it as a single-line expression, for uniform code style.

mscdex added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Jan 21, 2016

Fishrock123 commented Jan 21, 2016

Copy link
Copy Markdown
Contributor

I think usually keeping the braces will help understandability in docs for newcomers.

cc @nodejs/documentation

evanlucas commented Jan 21, 2016

Copy link
Copy Markdown
Contributor

+1 to keeping the braces

cjihrig commented Jan 21, 2016

Copy link
Copy Markdown
Contributor

Also +1 to keeping braces.

LGTM as is.

chrisdickinson commented Jan 21, 2016

Copy link
Copy Markdown
Contributor

LGTM. The brace/no-brace disagreement emphasizes the degree to which we need to put a linter in the doctool.

benjamingr commented Jan 21, 2016

Copy link
Copy Markdown
Member

Related nodejs/docs#62

silverwind pushed a commit that referenced this pull request Jan 26, 2016
doc: remove unnecessary bind(this)
2c42635 
PR-URL: #4797
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chris Dickinson <chris@neversaw.us>
Reviewed-By: Roman Reiss <me@silverwind.io>

silverwind commented Jan 26, 2016

Copy link
Copy Markdown
Contributor

Thanks! Landed in 2c42635.

silverwind closed this Jan 26, 2016
rvagg pushed a commit that referenced this pull request Jan 27, 2016
doc: remove unnecessary bind(this)
6acbf21 
PR-URL: #4797
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chris Dickinson <chris@neversaw.us>
Reviewed-By: Roman Reiss <me@silverwind.io>
benjamingr pushed a commit to benjamingr/io.js that referenced this pull request Jan 27, 2016
doc: remove unnecessary bind(this)
4b876bf 
PR-URL: nodejs#4797
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chris Dickinson <chris@neversaw.us>
Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg pushed a commit that referenced this pull request Feb 8, 2016
doc: remove unnecessary bind(this)
19ed619 
PR-URL: #4797
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chris Dickinson <chris@neversaw.us>
Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
doc: remove unnecessary bind(this)
25295ad 
PR-URL: #4797
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chris Dickinson <chris@neversaw.us>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
doc: remove unnecessary bind(this)
0887208 
PR-URL: #4797
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chris Dickinson <chris@neversaw.us>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
doc: remove unnecessary bind(this)
cb09203 
PR-URL: #4797
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chris Dickinson <chris@neversaw.us>
Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
doc: remove unnecessary bind(this)
594785b 
PR-URL: nodejs#4797
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chris Dickinson <chris@neversaw.us>
Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL