FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: fix type sniffing for properties in JSON generation by TimothyGu · Pull Request #4884 · nodejs/node · GitHub

/ node Public

tools: fix type sniffing for properties in JSON generation - #4884

Closed
TimothyGu wants to merge 1 commit into
nodejs:masterfrom
TimothyGu:type-in-props
ConversationCommits (1)ChecksFiles changed
Closed

tools: fix type sniffing for properties in JSON generation#4884
TimothyGu wants to merge 1 commit into
nodejs:masterfrom
TimothyGu:type-in-props

Conversation

TimothyGu commented Jan 26, 2016

Copy link
Copy Markdown
Member

Before:

            {
              "textRaw": "`children` {Array} ",
              "name": "children",
              "desc": "<p>The module objects required by this one.\n\n</p>\n"
            },

(https://nodejs.org/api/modules.json)

After:

            {
              "textRaw": "`children` {Array} ",
              "type": "Array",
              "name": "children",
              "desc": "<p>The module objects required by this one.\n\n</p>\n"
            },

mscdex added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. and removed doc Issues and PRs related to the documentations. labels Jan 26, 2016

mscdex commented Jan 26, 2016

Copy link
Copy Markdown
Contributor

LGTM with a couple of nits: the commit should target tools: instead of doc: and the first line of the commit message needs to be 50 characters or less.

TimothyGu commented Jan 26, 2016

Copy link
Copy Markdown
Member Author

@mscdex, done.

jasnell commented Jan 27, 2016

Copy link
Copy Markdown
Member

LGTM

mscdex changed the title doc: fix type sniffing for properties in JSON generation tools: fix type sniffing for properties in JSON generation Jan 27, 2016

TimothyGu commented Jan 30, 2016

Copy link
Copy Markdown
Member Author

Ping.

Trott commented Jan 30, 2016

Copy link
Copy Markdown
Member

I don't think running CI does anything with tools/doc/json.js but just in case...

CI: https://ci.nodejs.org/job/node-test-pull-request/1442/

Trott commented Jan 30, 2016

Copy link
Copy Markdown
Member

Not sure what's up with the ARM hosts in CI right now (stuck in pending, won't start a CI run) but everything else is green.

This probably isn't even anything anyone will ever run on ARM anyway since it's internal tooling.

And CI doesn't even exercise this code, so the CI run is kind of a symbolic gesture more than anything else.

So, will land in another minute or two...

Trott commented Jan 30, 2016

Copy link
Copy Markdown
Member

Landed in 5d8c192b42bd4f9bbdc20fd22bb797663901718c

Trott closed this Jan 30, 2016
TimothyGu deleted the type-in-props branch January 30, 2016 18:54
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 30, 2016
tools: add property types in JSON documentation
ab45390 
PR-URL: nodejs#4884
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

Trott commented Jan 30, 2016

Copy link
Copy Markdown
Member

Landed in ab45390

rvagg pushed a commit that referenced this pull request Feb 8, 2016
tools: add property types in JSON documentation
5d55f59 
PR-URL: #4884
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
tools: add property types in JSON documentation
18fbdd9 
PR-URL: #4884
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
tools: add property types in JSON documentation
bcb327c 
PR-URL: #4884
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
tools: add property types in JSON documentation
55cc86b 
PR-URL: #4884
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
tools: add property types in JSON documentation
588ecc4 
PR-URL: nodejs#4884
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL