FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix reference to API `hash.final` by JungMinu · Pull Request #5050 · nodejs/node · GitHub

/ node Public

doc: fix reference to API hash.final - #5050

Closed
JungMinu wants to merge 1 commit into
nodejs:masterfrom
JungMinu:doc-api
Closed

doc: fix reference to API hash.final#5050
JungMinu wants to merge 1 commit into
nodejs:masterfrom
JungMinu:doc-api

Conversation

JungMinu commented Feb 3, 2016

Copy link
Copy Markdown
Member

fix a reference to a non-existent API, hash.final().
It should be hash.digest().

JungMinu added the doc Issues and PRs related to the documentations. label Feb 3, 2016
JungMinu self-assigned this Feb 3, 2016

stevemao commented Feb 3, 2016

Copy link
Copy Markdown
Contributor

LGTM

mscdex added the crypto Issues and PRs related to the crypto subsystem. label Feb 3, 2016

jasnell commented Feb 3, 2016

Copy link
Copy Markdown
Member

LGTM

2 similar comments

Copy link
Copy Markdown
Contributor

LGTM

cjihrig commented Feb 3, 2016

Copy link
Copy Markdown
Contributor

LGTM

fix a reference to a non-existent API, `hash.final()`.
It should be `hash.digest()`.

PR-URL: #5050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
JungMinu added a commit that referenced this pull request Feb 4, 2016
fix a reference to a non-existent API, `hash.final()`.
It should be `hash.digest()`.

PR-URL: #5050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

JungMinu commented Feb 4, 2016

Copy link
Copy Markdown
Member Author

Thanks, landed in 34a5019

JungMinu closed this Feb 4, 2016
JungMinu deleted the doc-api branch February 4, 2016 13:20
rvagg pushed a commit that referenced this pull request Feb 8, 2016
fix a reference to a non-existent API, `hash.final()`.
It should be `hash.digest()`.

PR-URL: #5050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
fix a reference to a non-existent API, `hash.final()`.
It should be `hash.digest()`.

PR-URL: #5050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
fix a reference to a non-existent API, `hash.final()`.
It should be `hash.digest()`.

PR-URL: #5050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
fix a reference to a non-existent API, `hash.final()`.
It should be `hash.digest()`.

PR-URL: #5050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
fix a reference to a non-existent API, `hash.final()`.
It should be `hash.digest()`.

PR-URL: nodejs#5050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL