test: fix flaky cluster test on Windows 10 - #4934
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary .send() calls and replace with .disconnect() to avoid spurious EPIPE. Fixes: nodejs#4887 PR-URL: nodejs#4934
Trott
force-pushed
the
fix-flaky-again
branch
from
eff1ecf to
3b560ad
Compare
January 28, 2016 21:19
Copy link
Copy Markdown
Member
Author
|
Here are stress tests with this fix:
Here are stress tests without this fix:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Confirmed that the test still throws an AssertionError in Node 4.2.1 (which has the bug that this test is written to detect) and runs without throwing any errors in Node 4.2.2 (which has the fix for the bug). $ nvm use 4.2.1
Now using node v4.2.1 (npm v2.14.7)
$ node test/parallel/test-cluster-shared-leak.js
assert.js:89
throw new assert.AssertionError({
^
AssertionError: Resource leak detected.
at removeWorker (cluster.js:328:9)
at ChildProcess.<anonymous> (cluster.js:348:34)
at ChildProcess.g (events.js:260:16)
at emitTwo (events.js:87:13)
at ChildProcess.emit (events.js:172:7)
at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
$ nvm use 4.2.2
Now using node v4.2.2 (npm v2.14.7)
$ node test/parallel/test-cluster-shared-leak.js
$
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
CI is green! \o/ |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
lts watch tag applied. LGTM |
Sorry, something went wrong.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 31, 2016
test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary .send() calls and replace with .disconnect() to avoid spurious EPIPE. Fixes: nodejs#4887 PR-URL: nodejs#4934 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary .send() calls and replace with .disconnect() to avoid spurious EPIPE. Fixes: nodejs#4887 PR-URL: nodejs#4934 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: fix flaky cluster test on Windows 10
test-cluster-shared-leak was flaky on Windows 10. Remove unnecessary
.send() calls and replace with .disconnect() to avoid spurious EPIPE.