FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark test-tick-processor flaky by Trott · Pull Request #4809 · nodejs/node · GitHub

/ node Public

test: mark test-tick-processor flaky - #4809

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:mark-test-tick-processor
ConversationCommits (1)ChecksFiles changed
Closed

test: mark test-tick-processor flaky#4809
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:mark-test-tick-processor

Conversation

Trott commented Jan 21, 2016

Copy link
Copy Markdown
Member

Ref: #4427

Recent sample failures:

Trott added v8 engine Issues and PRs related to the V8 dependency. test Issues and PRs related to the tests. labels Jan 21, 2016

jasnell commented Jan 22, 2016

Copy link
Copy Markdown
Member

@Trott ... is this flakiness due to recent changes or would this need to be marked in LTS also?

Trott commented Jan 22, 2016

Copy link
Copy Markdown
Member Author

@jasnell This should apply to LTS as well.

Trott commented Jan 24, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/1360/

/cc @nodejs/testing (looking for an LGTM on this, seems like it should be non-controversial)

jasnell commented Jan 24, 2016

Copy link
Copy Markdown
Member

LGTM
On Jan 23, 2016 11:35 PM, "Rich Trott" notifications@github.com wrote:

CI: https://ci.nodejs.org/job/node-test-pull-request/1360/

/cc @nodejs/testing https://github.com/orgs/nodejs/teams/testing
(looking for an LGTM on this, seems like it should be non-controversial)

—
Reply to this email directly or view it on GitHub
#4809 (comment).

jbergstroem commented Jan 24, 2016

Copy link
Copy Markdown
Member

LGTM 😢

cjihrig commented Jan 24, 2016

Copy link
Copy Markdown
Contributor

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Jan 25, 2016
test: mark test-tick-processor flaky
c6d29cb 
PR-URL: nodejs#4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#4427

Trott commented Jan 25, 2016

Copy link
Copy Markdown
Member Author

Landed in c6d29cb

Trott closed this Jan 25, 2016
rvagg pushed a commit that referenced this pull request Jan 25, 2016
test: mark test-tick-processor flaky
ae9a8cd 
PR-URL: #4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: #4427
benjamingr pushed a commit to benjamingr/io.js that referenced this pull request Jan 27, 2016
test: mark test-tick-processor flaky
0e16694 
PR-URL: nodejs#4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#4427

jasnell commented Jan 27, 2016

Copy link
Copy Markdown
Member

@Trott .. I marked this lts-watch for v4.. can you confirm that tho? Not sure when this went flaky

Trott commented Jan 28, 2016

Copy link
Copy Markdown
Member Author

@jasnell I ran a stress test against the v4.x branch and the test is flaky there, so yes, confirmed. https://ci.nodejs.org/job/node-stress-single-test/377/nodes=win2008r2/console

rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
test: mark test-tick-processor flaky
78449b6 
PR-URL: #4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: #4427
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
test: mark test-tick-processor flaky
0a44e6a 
PR-URL: #4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: #4427
MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
test: mark test-tick-processor flaky
183bdef 
PR-URL: #4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: #4427
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
test: mark test-tick-processor flaky
3e1caee 
PR-URL: nodejs#4809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#4427
Trott deleted the mark-test-tick-processor branch January 13, 2022 22:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL