FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix inconsistent styling by mscdex · Pull Request #4996 · nodejs/node · GitHub

/ node Public

doc: fix inconsistent styling - #4996

Closed
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:doc-tls-fix-styling
ConversationCommits (1)ChecksFiles changed
Closed

doc: fix inconsistent styling#4996
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:doc-tls-fix-styling

Conversation

mscdex commented Jan 31, 2016

Copy link
Copy Markdown
Contributor

No description provided.

mscdex added tls Issues and PRs related to the tls subsystem. doc Issues and PRs related to the documentations. labels Jan 31, 2016
Trott reviewed Jan 31, 2016
View reviewed changes
Comment thread doc/api/tls.markdown Outdated

Trott Jan 31, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit, while you're in there: Remove personal pronoun.

Before:

You could provide an issuer via ca option.

After, something like:

An issuer may be provided via the ca option.

Trott commented Jan 31, 2016

Copy link
Copy Markdown
Member

LGTM with a take-it-or-leave-it nit.

targos commented Jan 31, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell commented Feb 1, 2016

Copy link
Copy Markdown
Member

LGTM with nit addressed

mscdex force-pushed the doc-tls-fix-styling branch from 3bcc34f to cad34b3 Compare February 4, 2016 02:30

mscdex commented Feb 4, 2016

Copy link
Copy Markdown
Contributor Author

Wording changed as suggested.

cjihrig commented Feb 4, 2016

Copy link
Copy Markdown
Contributor

LGTM

2 similar comments

DavidTPate commented Feb 4, 2016

Copy link
Copy Markdown

LGTM

jasnell commented Feb 4, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell pushed a commit that referenced this pull request Feb 4, 2016
doc: fix inconsistent styling
01dd8ed 
PR-URL: #4996
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Feb 4, 2016

Copy link
Copy Markdown
Member

Landed in 01dd8ed

jasnell closed this Feb 4, 2016
mscdex deleted the doc-tls-fix-styling branch February 4, 2016 19:14
rvagg pushed a commit that referenced this pull request Feb 8, 2016
doc: fix inconsistent styling
e5134b1 
PR-URL: #4996
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg mentioned this pull request Feb 8, 2016
Closed

MylesBorins commented Feb 18, 2016

Copy link
Copy Markdown
Contributor

The changes in this are fairly minor, not landing cleanly, and bringing over other changes.

I'm changing to dont-land for now. Please feel free to manually backport or get the conversation going again

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
doc: fix inconsistent styling
8d517ba 
PR-URL: nodejs#4996
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL