FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: Crypto.markdown 'RSA-SHA256' should be uppercase by raineroviir · Pull Request #5044 · nodejs/node · GitHub

/ node Public

doc: Crypto.markdown 'RSA-SHA256' should be uppercase - #5044

Closed
raineroviir wants to merge 3 commits into
nodejs:masterfrom
raineroviir:patch-1
ConversationCommits (3)ChecksFiles changed
Closed

doc: Crypto.markdown 'RSA-SHA256' should be uppercase#5044
raineroviir wants to merge 3 commits into
nodejs:masterfrom
raineroviir:patch-1

Conversation

raineroviir commented Feb 2, 2016

Copy link
Copy Markdown
Contributor

doc: Crypto.markdown 'RSA-SHA256' should be uppercase

Update crypto.markdown
decc2e1 
The RSA-SHA256 string should be uppercase
raineroviir mentioned this pull request Feb 2, 2016
Closed
r-52 added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. lts-watch-v4.x labels Feb 2, 2016

mscdex commented Feb 2, 2016

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment

jasnell commented Feb 2, 2016

Copy link
Copy Markdown
Member

LGTM

bnoordhuis commented Feb 2, 2016

Copy link
Copy Markdown
Member

LGTM but the commit log should follow the style guide from CONTRIBUTING.md.

cjihrig commented Feb 2, 2016

Copy link
Copy Markdown
Contributor

LGTM

raineroviir changed the title Update crypto.markdown crypto, doc: Crypto.markdown 'RSA-SHA256' should be uppercase Feb 2, 2016
raineroviir changed the title crypto, doc: Crypto.markdown 'RSA-SHA256' should be uppercase doc: Crypto.markdown 'RSA-SHA256' should be uppercase Feb 2, 2016

stevemao commented Feb 2, 2016

Copy link
Copy Markdown
Contributor

@raineroviir you need to change the commit message and force push to your branch.

raineroviir commented Feb 2, 2016

Copy link
Copy Markdown
Contributor Author

@stevemao I was able to amend the commit message and create a detached head but when I try to force push to my branch it says nothing was changed

stevemao commented Feb 2, 2016

Copy link
Copy Markdown
Contributor

Don't checkout the previous commit.
The easiest way to do this is git commit --amend fix the commit message then git push -f

@raineroviir https://help.github.com/articles/changing-a-commit-message/

doc: Crypto.markdown 'RSA-SHA256' should be uppercase
9689e25 
doc: Crypto.markdown 'RSA-SHA256' should be uppercase
Merge pull request #1 from raineroviir/origin/patch-1
18a3f63 
doc: Crypto.markdown 'RSA-SHA256' should be uppercase

raineroviir commented Feb 3, 2016

Copy link
Copy Markdown
Contributor Author

@stevemao thanks! decc2e1 commit message hasn't changed but I believe I made the changes

stevemao commented Feb 3, 2016

Copy link
Copy Markdown
Contributor

Well, I guess you probably need to squash now... But I think someone can do it on merge so don't worry!

bnoordhuis pushed a commit that referenced this pull request Feb 3, 2016
doc: uppercase 'RSA-SHA256' in crypto.markdown
977159f 
Fixes: #5031
PR-URL: #5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

bnoordhuis commented Feb 3, 2016

Copy link
Copy Markdown
Member

@raineroviir Here is what I would do:

  1. git reflog and find the hash of your original commit.
  2. git reset --hard <commit>
  3. git commit --amend
  4. git push your-remote +HEAD:patch-1

I landed your patch with a slightly amended commit log (< 50 characters) in commit 977159f. Thanks!

bnoordhuis closed this Feb 3, 2016

raineroviir commented Feb 3, 2016

Copy link
Copy Markdown
Contributor Author

Thank you!

rvagg pushed a commit that referenced this pull request Feb 8, 2016
doc: uppercase 'RSA-SHA256' in crypto.markdown
9908ece 
Fixes: #5031
PR-URL: #5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
doc: uppercase 'RSA-SHA256' in crypto.markdown
ed92350 
Fixes: #5031
PR-URL: #5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
doc: uppercase 'RSA-SHA256' in crypto.markdown
dee5045 
Fixes: #5031
PR-URL: #5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
doc: uppercase 'RSA-SHA256' in crypto.markdown
e6663c5 
Fixes: #5031
PR-URL: #5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
doc: uppercase 'RSA-SHA256' in crypto.markdown
beb2651 
Fixes: nodejs#5031
PR-URL: nodejs#5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL