FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix redeclared vars in test-vm-* by Trott · Pull Request #4997 · nodejs/node · GitHub

/ node Public

test: fix redeclared vars in test-vm-* - #4997

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:test-vm-no-redeclare
Closed

test: fix redeclared vars in test-vm-*#4997
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:test-vm-no-redeclare

Conversation

Trott commented Jan 31, 2016

Copy link
Copy Markdown
Member

No description provided.

Trott added vm Issues and PRs related to the vm subsystem. test Issues and PRs related to the tests. lts-watch-v4.x labels Jan 31, 2016

targos commented Jan 31, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell commented Feb 1, 2016

Copy link
Copy Markdown
Member

LGTM if CI is green: https://ci.nodejs.org/job/node-test-pull-request/1472/

cjihrig commented Feb 1, 2016

Copy link
Copy Markdown
Contributor

LGTM

jasnell pushed a commit that referenced this pull request Feb 1, 2016
PR-URL: #4997
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Feb 1, 2016

Copy link
Copy Markdown
Member

Landed in 5f44475

jasnell closed this Feb 1, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
PR-URL: #4997
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
PR-URL: #4997
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
PR-URL: #4997
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Feb 18, 2016
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
PR-URL: #4997
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4997
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott deleted the test-vm-no-redeclare branch January 13, 2022 22:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL