FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: apply linting to doc tools by Trott · Pull Request #4973 · nodejs/node · GitHub

/ node Public

tools: apply linting to doc tools - #4973

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:eslint-doc
ConversationCommits (2)ChecksFiles changed
Closed

tools: apply linting to doc tools#4973
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:eslint-doc

Conversation

Trott commented Jan 30, 2016

Copy link
Copy Markdown
Member

Apply eslint rules to tools/doc.

Trott added tools Issues and PRs related to the tools directory. lts-watch-v4.x labels Jan 30, 2016

tflanagan commented Jan 30, 2016

Copy link
Copy Markdown
Contributor

👍

Fishrock123 commented Jan 30, 2016

Copy link
Copy Markdown
Contributor

LGTM if it still works

silverwind commented Jan 31, 2016

Copy link
Copy Markdown
Contributor

LGTM

targos reviewed Jan 31, 2016
View reviewed changes
Comment thread Makefile

targos Jan 31, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You also need to update the corresponding line in vcbuild.bat

Trott Jan 31, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah, yes, of course! Done! (If someone on a Windows machine can confirm that it still works on Windows, that would be great. I don't think we run lint on Windows in CI.)

tflanagan Feb 1, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Works great (Win10)

jasnell commented Feb 1, 2016

Copy link
Copy Markdown
Member

LGTM

Trott commented Feb 1, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/1490/

Trott commented Feb 1, 2016

Copy link
Copy Markdown
Member Author
  • Confirmed addon-verify.js still runs and generates identical output files when running ./node tools/doc/addon-verify.js on this version and on the version of the script in master branch.
  • Changes to generate.js seem very straightforward. Confirmed that version in master branch and this branch generate identical output using zlib.markdown as input, specifying both JSON and HTML output.
  • Changes to html.js, preprocess.js, and json.js tested in above step, as they are used by generate.js.

And CI is green to boot.

Trott added a commit to Trott/io.js that referenced this pull request Feb 2, 2016
tools: apply linting to doc tools
2d89d3d 
Apply eslint rules to `tools/doc`.

PR-URL: nodejs#4973
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

Trott commented Feb 2, 2016

Copy link
Copy Markdown
Member Author

Landed in 2d89d3d

Trott closed this Feb 2, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
tools: apply linting to doc tools
e95fd6a 
Apply eslint rules to `tools/doc`.

PR-URL: #4973
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
tools: apply linting to doc tools
a26c7a5 
Apply eslint rules to `tools/doc`.

PR-URL: #4973
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
tools: apply linting to doc tools
d1d220a 
Apply eslint rules to `tools/doc`.

PR-URL: #4973
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
tools: apply linting to doc tools
7fb5a03 
Apply eslint rules to `tools/doc`.

PR-URL: #4973
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
tools: apply linting to doc tools
80c92c3 
Apply eslint rules to `tools/doc`.

PR-URL: nodejs#4973
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Trott deleted the eslint-doc branch January 13, 2022 22:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL