tools: add support for subkeys in release tools - #4807
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
I'm not 100% we want to be using the -E flag here. Personally I don't see a problem, but perhaps we want to solve this without using an extended regular expression
Sorry, something went wrong.
|
As a note, my subkey works, but it always prints the "GPG key for \"${version}\" tag is not yours, cannot sign" error. (Because something detects my master key instead, and git ends up signing with a subkey. (I think?)) |
Sorry, something went wrong.
|
Any thoughts on this @rvagg ? |
Sorry, something went wrong.
|
Yeah, this works, I was working up a complicated solution in my head but the fact that this simply prompts you to choose makes it a simple fix! Good thinking. grep '^sec\|^ssb' works without the -E but we may as well just roll it up into the awk with: gpgkey=$(gpg --list-secret-keys | awk -F'( +|/)' '/^(sec|ssb)/{print $3}')
lgtm with that change. |
Sorry, something went wrong.
|
@rvagg I added the change and rebased against master |
Sorry, something went wrong.
|
lgtm, I think you can probably land this at will now, thanks @thealphanerd! |
Sorry, something went wrong.
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <rod@vagg.org>
Replace grep with awk to add support for subkeys PR-URL: #4807 Reviewed-By: Rod Vagg <rod@vagg.org>
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <rod@vagg.org>
Replace grep with awk to add support for subkeys PR-URL: #4807 Reviewed-By: Rod Vagg <rod@vagg.org>
Replace grep with awk to add support for subkeys PR-URL: #4807 Reviewed-By: Rod Vagg <rod@vagg.org>
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <rod@vagg.org>
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <rod@vagg.org>
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <rod@vagg.org>
Replace grep with awk to add support for subkeys
/cc @rvagg @jasnell @Fishrock123 @nodejs/build