V4.3.1 proposal by MylesBorins · Pull Request #5200 · nodejs/node · GitHub

Notable changes

buffer
- make byteLength work with Buffer correctly (Jackson Tian)
  - #4738
debugger
- guard against call from non-node context (Ben Noordhuis)
  - #4328
  - fixes segfaults in debugger
- do not incept debug context (Myles Borins)
  - #4815
  - fixes crash in debugger when using util methods
deps
- update to http-parser 2.5.2 (James Snell)
  - #5238

Commits

[748d2b4de1] - buffer: make byteLength work with Buffer correctly (Jackson Tian) #4738
[fb615bdaf4] - buffer: remove unnecessary TODO comments (Peter Geiss) #4719
[b8213ba7e1] - cluster: ignore queryServer msgs on disconnection (Santiago Gimeno) #4465
[f8a676ed59] - cluster: fix race condition setting suicide prop (Santiago Gimeno) #4349
[9d4a226dad] - crypto: clear error stack in ECDH::Initialize (Fedor Indutny) #4689
[583f3347d8] - debugger: remove variable redeclarations (Rich Trott) #4633
[667f7a7ab3] - debugger: guard against call from non-node context (Ben Noordhuis) #4328
[188cff3c31] - deps: update to http-parser 2.5.2 (James Snell) #5238
[6e829b44e3] - dgram: prevent disabled optimization of bind() (Brian White) #4613
[c3956d05b1] - doc: update list of personal traits in CoC (Kat Marchán) #4801
[39cb69ca21] - doc: style fixes for the TOC (Roman Reiss) #4748
[cb5986da81] - doc: add servername parameter docs (Alexander Makarenko) #4729
[91066b5f34] - doc: update branch-diff arguments in release doc (Rod Vagg) #4691
[9ca24de41d] - doc: add docs for more stream options (zoubin) #4639
[437d0e336d] - doc: mention that http.Server inherits from net.Server (Ryan Sobol) #4455
[393e569160] - doc: copyedit setTimeout() documentation (Rich Trott) #4434
[e2a682ecc3] - doc: fix formatting in process.markdown (Rich Trott) #4433
[75b0ea85bd] - doc: add path property to Write/ReadStream in fs.markdown (Claudio Rodriguez) #4368
[48c2783421] - doc: add docs working group (Bryan English) #4244
[c0432e9f56] - doc: restore ICU third-party software licenses (Richard Lau) #4762
[36a4159dab] - doc: rebuild LICENSE using tools/license-builder.sh (Rod Vagg) #4194
[a2998a1bce] - gitignore: never ignore debug module (Michaël Zasso) #2286
[661b2557d9] - http: remove variable redeclaration (Rich Trott) #4612
[1bb2967d48] - http: fix non-string header value concatenation (Brian White) #4460
[15ed64e34c] - lib: fix style issues after eslint update (Michaël Zasso) nodejs/io.js#2286
[2e92a1a6b4] - module: move unnecessary work for early return (Andres Suarez) #3579
[40c8e6d75d] - net: remove hot path comment from connect (Evan Lucas) #4648
[8ed0c1c22c] - net: fix dns lookup for android (Josh Dague) #4580
[15fa555204] - net, doc: fix line wrapping lint in net.js (James M Snell) #4588
[1b070e48e0] - node_contextify: do not incept debug context (Myles Borins) #4815
[4fbcb47fe9] - readline: Remove XXX and output debuglog (Kohei TAKATA) #4690
[26f02405d0] - repl: make sure historyPath is trimmed (Evan Lucas) #4539
[5990ba2a0a] - src: remove redeclarations of variables (Rich Trott) #4605
[c41ed59dbc] - src: don't check failure with ERR_peek_error() (Ben Noordhuis) #4731
[d71f9992f9] - stream: remove useless if test in transform (zoubin) #4617
[f205e9920e] - test: fix tls-no-rsa-key flakiness (Santiago Gimeno) #4043
[447347cd62] - test: fix issues for space-in-parens ESLint rule (Roman Reiss) #4753
[be8274508c] - test: improve test-cluster-disconnect-suicide-race (Rich Trott) #4739
[0178001163] - test: make test-cluster-disconnect-leak reliable (Rich Trott) #4736
[d615757da2] - test: fix flaky test-net-socket-local-address (cjihrig) #4650
[baa0a3dff5] - test: fix race in test-net-server-pause-on-connect (Rich Trott) #4637
[909b5167cb] - test: remove 1 second delay from test (Rich Trott) #4616
[8ea76608ed] - test: move resource intensive tests to sequential (Rich Trott) #4615
[7afcdd358e] - test: require common module only once (Rich Trott) #4611
[0e02eb0bbe] - test: only include http module once (Rich Trott) #4606
[34d9e48bb6] - test: fix http-upgrade-client flakiness (Santiago Gimeno) #4602
[556703d531] - test: fix flaky unrefed timers test (Rich Trott) #4599
[3d5bc69796] - test: fix http-upgrade-agent flakiness (Santiago Gimeno) #4520
[ec24d3767b] - test: fix flaky test-cluster-shared-leak (Rich Trott) #4510
[a256790327] - test: fix flaky cluster-net-send (Brian White) #4444
[6809c2be1a] - test: fix flaky child-process-fork-regr-Segfault in node::StreamBase::GetFD #2847 (Brian White) #4442
[e6448aa36b] - test: use addon.md block headings as test dir names (Rod Vagg) #4412
[305d340fca] - test: test each block in addon.md contains js & cc (Rod Vagg) #4411
[f213406575] - test: fix tls-multi-key race condition (Santiago Gimeno) #3966
[607f545568] - test: fix style issues after eslint update (Michaël Zasso) nodejs/io.js#2286
[aefb20a94f] - tls: copy client CAs and cert store on CertCb (Fedor Indutny) #3537
[7821b3e305] - tls_legacy: do not read on OpenSSL's stack (Fedor Indutny) #4624
[b66db49f94] - tools: add support for subkeys in release tools (Myles Borins) #4807
[837ebd1985] - tools: enable space-in-parens ESLint rule (Roman Reiss) #4753
[066d5e7da2] - tools: fix style issue after eslint update (Michaël Zasso) nodejs/io.js#2286
[b20ea69f46] - tools: update eslint config (Michaël Zasso) nodejs/io.js#2286
[2e0352d50c] - tools: update eslint to v1.10.3 (Michaël Zasso) nodejs/io.js#2286
[c96800a432] - tools: fix license-builder.sh for ICU (Richard Lau) #4762
[720b03dca7] - tools: add license-builder.sh to construct LICENSE (Rod Vagg) #4194

CI: https://ci.nodejs.org/job/node-test-pull-request/1642/
citgm: https://ci.nodejs.org/job/thealphanerd-smoker/69/

edit: ARM CI failure is known flaky test. Fix should land in next release
#5125

edit: citgm is green! (known failure on ppc)

Build Job for rc1: https://ci.nodejs.org/job/iojs+release/393/

LGTM if CI is green.
@nodejs/lts @nodejs/collaborators ... the plan is to start a regular Release Candidate cycle for all regular LTS releases. The 4.3.1-rc.1 should be available soon with the actual release expected on Tuesday of next week if everything looks good. For the upcoming minor bump to 4.4, we'll do a RC cycle of at least a week before cutting the actual release. To avoid regressions and to make sure these releases are stable, we need as many people as possible to test the RC's.

Failures on windows

custom_actions.vcxproj -> c:\workspace\iojs+release\nodes\win2008r2-release-ia32\tools\msvs\msi\Release\custom_actions.dll
light.exe : error LGHT0103: The system cannot find the file '..\..\..\deps\npm\\node_modules\npm-install-checks\node_modules\npmlog\node_modules\gauge\node_modules\lodash.padright\node_modules\lodash._createpadding\node_modules\lodash.repeat\package.json' with type ''. [c:\workspace\iojs+release\nodes\win2008r2-release-ia32\tools\msvs\msi\nodemsi.wixproj]
Build step 'Conditional steps (multiple)' marked build as failure

Digging into npm tree changes

oy.. I think this has come up before. /cc @zkat

Yeaaaaah. It's tricky cause we can't just flatten the tree -- I'll talk with folks tomorrow and see if we can come up with a solution that fixes this without breaking everything else.

@thealphanerd would you mind putting PR links in the Notable changes section along with attribution, it just makes it easier to click through to find stuff.
[c8cc179] - querystring: improve parse() performance (Brian White) querystring: improve parse() performance #4675 is a little bit of a concern, mainly because that kind of change is so ripe for finding edge cases. We've been through one release cycle with this change in 5.5.0 but I'm still hesitant. This one's not as big as a couple of the other recent perf improvements (mainly where they involve unwinding a regex with a long, complicated function) so it's borderline for me and I think I'd even prefer holding it off in staging for a little longer.
[d8fbefc] - buffer: make byteLength work with Buffer correctly (Jackson Tian) buffer: make byteLength work with Buffer correctly #4738 is another borderline for me, it's clearly a bug that needed to be fixed but it's also a breaking change if you happen to be relying on the existing (buggy) way it works. Not an objection for this release, but I'm wondering if we should create another bucket (label or branch) to put these kind of borderline changes in so we can consider them in isolation from the rest.

Lastly, @thealphanerd, how's the cherry-picking going? I'm experiencing a little bit of pain when doing v5.x as we move on but I imagine v4.x-staging is even more difficult.

@rvagg

I'll update the commit / changelog tomorrow.
let's hold c8cc179 back from this release and put it into the next release, which itself will have a longer rc phase.
should we make an issue on http://github.com/nodejs/lts?

Lastly, not real problems with cherry-picking tbqh. I wonder if the staging branch has made things a bit simpler?

+1 to being conservative with the perf related fixes. I want to make sure we start doing a RC cycle with every LTS release so we can catch issues faster but we definitely need everyone to help test to make that effective.

I think the cherry-picking in v4.x is going fairly smooth because we are also avoiding the semver-minor bumps.

So it looks like there are a handful of things going on with npm

4.2.4 had a similar issue but managed to avoid it via deduping

The same dedupe is not working anymore.

These problems are present in npm-install-check... specifically in the tree of gauge, which is no longer deduping specific lodash dependencies.

I have sent a PR over to gauge that updates the lodash dependency. The updated lodash modules have significantly shallower trees, doing away with the two modules that are being repeated and not deduping. This alone may fix the problem.

It also appears that npm-install-checks and node-gyp are relying on older / incompatible versions of npm-log... which may be adding to the weirdness.

At this point I am ready to revert the npm updates so that we can get and RC out... but I would really like to avoid that as there are some bugs that are being fixed by the npm update

/cc @nodejs/npm

It looks like there is an open PR to update npmlog in node-gyp. @rvagg can you escalate this?

nodejs/node-gyp#861

It looks like npm-install-checks that is present in npm v2 is two versions behind. The latest version doesn't even have npmlog as a dep anymore. I'm going to experiment with updating that dep and seeing if that helps

edit: talked to @zkat version 2 - 3 do not work with npm@2. It might be possible to release a new version of the 1.x line with an updated npmlog

So i've gone through and removed the updates to npm for now. I've also backed out c8cc179 as requested by @rvagg

ci: https://ci.nodejs.org/job/node-test-pull-request/1648/
citgm: https://ci.nodejs.org/job/thealphanerd-smoker/71/

edit:
CI failure on arm is expected #4830
CI failures on linux are all infra related

edit:
citgm failure on fedora21 appears to be infra related, single failing test due to timing out in the Jade test suite.

fwiw, working on getting a semver-minor update of node-gyp out in the next few days with that npmlog fix plus hopefully nodejs/node-gyp#877 and nodejs/node-gyp#878.

rc2 build in progress: https://ci.nodejs.org/job/iojs+release/397/

@nodejs/collaborators ... just a heads up... please help us test this release candidate for v4.3.1 : https://nodejs.org/download/rc/v4.3.1-rc.2/

Hey, I'd like to lobby for including #4482 in this release. We're hitting the idle socket timeout this commit fixes, and currently have to cherry pick this commit into Node v4 and build from source as a workaround.

@mikemorris this commit will be coming very soon in v4.4.0
You should expect an RC with those updates in the next 24 - 48 hours.

We are trying to get 4.3 as stable as possible with this update and then as quickly as possible get out a release with a few semver minor addition, including #4482

It's possible there is already an existing error on OpenSSL's error stack that is unrelated to the EVP_DigestInit_ex() operation we just executed. Fixes: nodejs#4221 PR-URL: nodejs#4731 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>

Fix a segmentation fault when the debug message handler was called from a context without an associated `node::Environment`. Fixes: nodejs#4261 Fixes: nodejs#4322 PR-URL: nodejs#4328 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#4194 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: nodejs#4690 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#4691 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Refs: nodejs#4642 PR-URL: nodejs#4719 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Add `servername` parameter docs for `https.request()` method. Follows nodejs#4389 PR-URL: nodejs#4729 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>

Previously, test-cluster-disconnect-leak had two issues: * Magic numbers: How many times to spawn a worker was determined through empirical experimentation. This means that as new platforms and new CPU/RAM configurations are tested, the magic numbers require more and more refinement. This brings us to... * Non-determinism: The test *seems* to fail all the time when the bug it tests for is present, but it's really a judgment based on sampling. "Oh, with 8 workers per CPU, it fails about 80% of the time. Let's try 16..." This revised version of the test takes a different approach. The fix for the bug that the test was written for means that the `disconnect` event will fire reliably for a single worker. So we check for that and the test still fails when the fix is not in the code base and succeeds when it is. Advantages of this approach include: * The test runs much faster. * The test now works on Windows. The previous version skipped Windows. * The test should be reliable on any new platform regardless of CPU and RAM. Ref: nodejs#4674 PR-URL: nodejs#4736 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

Make the byteLength work correctly when input is Buffer. e.g: ```js // The incomplete unicode string Buffer.byteLength(new Buffer([0xe4, 0xb8, 0xad, 0xe6, 0x96])) ``` The old output: 9 The new output: 5 PR-URL: nodejs#4738 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Previously, test-cluster-disconnect-suicide-race had two issues: * Magic numbers: How many times to spawn a worker was determined through empirical experimentation. This means that as new platforms and new CPU/RAM configurations are tested, the magic numbers require more and more refinement. This brings us to... * Non-determinism: The test seems to fail all the time when the bug it tests for is present, but it's really a judgment based on sampling. "Oh, with 8 workers per CPU, it fails about 80% of the time. Let's try 16..." This revised version of the test takes a different approach. The fix for the bug that the test was written for means that the disconnect event will fire on a subsequent tick. So we check for that and the test still fails when the fix is not in the code base and succeeds when it is. Advantages of this approach include: * The test runs much faster. * The test should be reliable on any new platform regardless of CPU and RAM. PR-URL: nodejs#4739 Ref: nodejs#4674 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

- Hide the scrollbar on the TOC on all browsers. It was never the intention for it to be visible with the scroll indication in place. A wrapper element with 20px padding was added to accommodate for hopefully all scrollbar widths as well as to avoid overflowing content. - Fixed the scroll indication gradient on Safari, which was caused by the wrong from-color, which now matches the to-color. - Fixed a issue in old IE where the TOC didn't render on the correct position through setting `left: 0` and `top: 0` on it. PR-URL: nodejs#4748 Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

Ref: http://eslint.org/docs/rules/space-in-parens.html PR-URL: nodejs#4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <mborins@us.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> PR-URL: nodejs#4801 Fixes: nodejs/inclusivity#82

Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <rod@vagg.org>

In some conditions it can happen that the client-side socket is destroyed before the server-side socket has gracefully closed, thus causing a 'ECONNRESET' error in this socket. To solve this, wait in the client-side socket for the 'end' event before closing it. PR-URL: nodejs#4043 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Currently a debug context is created for various calls to util. If the node debugger is being run the main context is the debug context. In this case node_contextify was freeing the debug context and causing everything to explode. This change moves around the logic and no longer frees the context. There is a concern about the dangling pointer The regression test was adapted from code submitted by @3y3 in nodejs#4815 Fixes: nodejs#4440 Fixes: nodejs#4815 Fixes: nodejs#4597 Fixes: nodejs#4952 PR-URL: nodejs#4815 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>

CI: https://ci.nodejs.org/job/node-test-pull-request/1670/
citgm: https://ci.nodejs.org/job/thealphanerd-smoker/74/

edit: CI failure is infra related
edit: citgm is all green except for expected failure on PPC with eslint

rc.3 build: https://ci.nodejs.org/job/iojs+release/398/

As we have not had any problems with any of the rc's I am going to move forward with this release in the next two hours.

Last chance to raise any concerns @nodejs/collaborators

Notable changes: * buffer: make byteLength work with Buffer correctly (Jackson Tian) - nodejs#4738 * debugger: guard against call from non-node context (Ben Noordhuis) - nodejs#4328 * node_contextify: do not incept debug context (Myles Borins) - nodejs#4819 * deps: update to http-parser 2.5.2 (James Snell) - nodejs#5238

@thealphanerd #5168 is a segfault fix, but it's a rare case and perhaps not worth the rush or delaying the release.

@ChALkeR I feel like that commit is still too fresh. I'll make sure to get it in the v4.4.0-rc

@thealphanerd I shortened the workspace of release machines from c:\workspace\iojs+release\nodes\win2008r2-release-ia32 to c:\ws. That allows rc1 above to build the MSI, but I won't be able to make it shorter if the tree depth of npm grows again.

@joaocgreis thanks for getting to that!

I'm going to avoid rolling the npm updates into this release as we are not assured that the path issues are solved after install. I'll roll all those updates into the next RC though!

Release Build: https://ci.nodejs.org/job/iojs+release/404/

PR-URL: #5200 (comment)

Notable changes: * buffer: make byteLength work with Buffer correctly (Jackson Tian) - #4738 * debugger: guard against call from non-node context (Ben Noordhuis) - #4328 * node_contextify: do not incept debug context (Myles Borins) - #4819 * deps: update to http-parser 2.5.2 (James Snell) - #5238 PR-URL: #5200 (comment)

MylesBorins force-pushed the v4.3.1-proposal branch 2 times, most recently from 5bdfd82 to b46ee1d Compare February 11, 2016 23:54

mscdex added the meta Issues and PRs related to the general management of the project. label Feb 12, 2016

MylesBorins added the v4.x label Feb 12, 2016

MylesBorins force-pushed the v4.3.1-proposal branch 3 times, most recently from c172a6a to 4a4661a Compare February 13, 2016 01:33

MylesBorins force-pushed the v4.3.1-proposal branch from 4a4661a to 5dd0c2f Compare February 13, 2016 02:10

mscdex mentioned this pull request Feb 13, 2016

Segmentation fault in native call binding.runInDebugContext #5217

Closed

bnoordhuis and others added 3 commits February 15, 2016 11:30

tools: add license-builder.sh to construct LICENSE

720b03d

PR-URL: nodejs#4194 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

kohei-takata and others added 14 commits February 15, 2016 11:30

readline: Remove XXX and output debuglog

4fbcb47

Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: nodejs#4690 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

doc: update branch-diff arguments in release doc

91066b5

PR-URL: nodejs#4691 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

buffer: remove unnecessary TODO comments

fb615bd

Refs: nodejs#4642 PR-URL: nodejs#4719 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

doc: add servername parameter docs

cb5986d

Add `servername` parameter docs for `https.request()` method. Follows nodejs#4389 PR-URL: nodejs#4729 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>

test: fix issues for space-in-parens ESLint rule

447347c

PR-URL: nodejs#4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

tools: enable space-in-parens ESLint rule

837ebd1

Ref: http://eslint.org/docs/rules/space-in-parens.html PR-URL: nodejs#4753 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

tools: add support for subkeys in release tools

b66db49

Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <rod@vagg.org>

MylesBorins force-pushed the v4.3.1-proposal branch from 5dd0c2f to 7ee5216 Compare February 15, 2016 19:40

MylesBorins force-pushed the v4.3.1-proposal branch from 7ee5216 to b321f13 Compare February 15, 2016 20:12

MylesBorins force-pushed the v4.3.1-proposal branch from b321f13 to ef37a46 Compare February 16, 2016 21:51

MylesBorins merged commit ef37a46 into nodejs:v4.x Feb 17, 2016

MylesBorins pushed a commit that referenced this pull request Feb 17, 2016

Working on v4.3.2

d442286

PR-URL: #5200 (comment)

MylesBorins deleted the v4.3.1-proposal branch March 2, 2016 20:23

V4.3.1 proposal by MylesBorins · Pull Request #5200 · nodejs/node · GitHub

Uh oh!

Uh oh!

V4.3.1 proposal - #5200

V4.3.1 proposal#5200MylesBorins merged 64 commits intonodejs:v4.xnodejs/node:v4.xfrom MylesBorins:v4.3.1-proposalMylesBorins/node:v4.3.1-proposalCopy head branch name to clipboard

Conversation

MylesBorins commented Feb 11, 2016

Notable changes

Commits

Uh oh!

MylesBorins commented Feb 11, 2016

Uh oh!

MylesBorins commented Feb 12, 2016

Uh oh!

jasnell commented Feb 12, 2016

Uh oh!

MylesBorins commented Feb 12, 2016

Uh oh!

jasnell commented Feb 12, 2016

Uh oh!

zkat commented Feb 12, 2016

Uh oh!

rvagg commented Feb 12, 2016

Uh oh!

MylesBorins commented Feb 12, 2016

Uh oh!

jasnell commented Feb 12, 2016

Uh oh!

MylesBorins commented Feb 13, 2016

Uh oh!

MylesBorins commented Feb 13, 2016

Uh oh!

MylesBorins commented Feb 13, 2016

Uh oh!

MylesBorins commented Feb 13, 2016

Uh oh!

rvagg commented Feb 13, 2016

Uh oh!

MylesBorins commented Feb 13, 2016

Uh oh!

jasnell commented Feb 13, 2016

Uh oh!

mikemorris commented Feb 15, 2016

Uh oh!

MylesBorins commented Feb 15, 2016

Uh oh!

MylesBorins commented Feb 15, 2016

Uh oh!

MylesBorins commented Feb 15, 2016

Uh oh!

MylesBorins commented Feb 16, 2016

Uh oh!

ChALkeR commented Feb 16, 2016

Uh oh!

MylesBorins commented Feb 16, 2016

Uh oh!

joaocgreis commented Feb 16, 2016

Uh oh!

MylesBorins commented Feb 16, 2016

Uh oh!

MylesBorins commented Feb 16, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

V4.3.1 proposal#5200
MylesBorins merged 64 commits into
nodejs:v4.xfrom
MylesBorins:v4.3.1-proposal