FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix DNS lookup on Android by daguej · Pull Request #4580 · nodejs/node · GitHub

/ node Public

Fix DNS lookup on Android - #4580

Closed
daguej wants to merge 1 commit into
nodejs:masterfrom
daguej:android-dns-fix
ConversationCommits (1)ChecksFiles changed
Closed

Fix DNS lookup on Android#4580
daguej wants to merge 1 commit into
nodejs:masterfrom
daguej:android-dns-fix

Conversation

daguej commented Jan 8, 2016

Copy link
Copy Markdown
Contributor

V4MAPPED isn't supported by Android either (as of 6.0).

Fixes #3771.

net: fix dns lookup for android
106aa9e 
`V4MAPPED` isn't supported by Android either (as of 6.0)
mscdex added dns Issues and PRs related to the dns subsystem. arm Issues and PRs related to the ARM architecture. labels Jan 8, 2016

jasnell commented Jan 8, 2016

Copy link
Copy Markdown
Member

LGTM but a test case would likely be helpful also (we do not currently run CI on Android, of course, but it would be handy to have).

jasnell commented Jan 8, 2016

Copy link
Copy Markdown
Member

@mscdex

cjihrig commented Jan 8, 2016

Copy link
Copy Markdown
Contributor

@daguej what is the value of dns.V4MAPPED on Android by chance?

daguej commented Jan 8, 2016

Copy link
Copy Markdown
Contributor Author

@cjihrig It's 2048.

cjihrig commented Jan 8, 2016

Copy link
Copy Markdown
Contributor

Ah, thanks. I was hoping it was undefined or something so we didn't have to explicitly check platform names.

cjihrig commented Jan 8, 2016

Copy link
Copy Markdown
Contributor

LGTM.

We might want to consider removing the implicit use of V4MAPPED in a future version. It seems to just cause problems.

mscdex commented Jan 8, 2016

Copy link
Copy Markdown
Contributor

LGTM

jasnell pushed a commit that referenced this pull request Jan 8, 2016
net: fix dns lookup for android
c64018e 
`V4MAPPED` isn't supported by Android either (as of 6.0)

PR-URL: #4580
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell commented Jan 8, 2016

Copy link
Copy Markdown
Member

Landed in c64018e

jasnell closed this Jan 8, 2016

daguej commented Jan 9, 2016

Copy link
Copy Markdown
Contributor Author

Thanks -- close #3771?

cjihrig commented Jan 9, 2016

Copy link
Copy Markdown
Contributor

Thanks. Closed it.

MylesBorins pushed a commit that referenced this pull request Jan 11, 2016
net: fix dns lookup for android
64a9b0d 
`V4MAPPED` isn't supported by Android either (as of 6.0)

PR-URL: #4580
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Jan 11, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jan 12, 2016
net: fix dns lookup for android
799aa74 
`V4MAPPED` isn't supported by Android either (as of 6.0)

PR-URL: #4580
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 28, 2016
net: fix dns lookup for android
c7129e7 
`V4MAPPED` isn't supported by Android either (as of 6.0)

PR-URL: #4580
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
net: fix dns lookup for android
96f5ff4 
`V4MAPPED` isn't supported by Android either (as of 6.0)

PR-URL: #4580
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
net: fix dns lookup for android
2b649b7 
`V4MAPPED` isn't supported by Android either (as of 6.0)

PR-URL: nodejs#4580
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Feb 11, 2016
Merged
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 15, 2016
net: fix dns lookup for android
8ed0c1c 
`V4MAPPED` isn't supported by Android either (as of 6.0)

PR-URL: nodejs#4580
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

rvagg commented Mar 22, 2016

Copy link
Copy Markdown
Member

I'm seeking some feedback about how Node.js is used on Android if anyone watching this thread would like to tell us about it: nodejs/build#359

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
net: fix dns lookup for android
a7e8ad1 
`V4MAPPED` isn't supported by Android either (as of 6.0)

PR-URL: nodejs#4580
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

arm Issues and PRs related to the ARM architecture. dns Issues and PRs related to the dns subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL