FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

V5.4.1 propose by MylesBorins · Pull Request #4626 · nodejs/node · GitHub

/ node Public

V5.4.1 propose - #4626

Merged
MylesBorins merged 27 commits into
v5.xfrom
v5.4.1-propose
Jan 12, 2016
ConversationCommits (27)ChecksFiles changed
Merged

V5.4.1 propose#4626
MylesBorins merged 27 commits into
v5.xfrom
v5.4.1-propose

Conversation

MylesBorins commented Jan 11, 2016

Copy link
Copy Markdown
Contributor

Notable Changes

  • Minor performance improvements:
    • module: move unnecessary work for early return (Andres Suarez) #3579
  • Various bug fixes
  • Various doc fixes
  • Various test improvements

Known issues

  • Surrogate pair in REPL can freeze terminal. #690
  • Calling dns.setServers() while a DNS query is in progress can cause the process to crash on a failed assertion. #894
  • url.resolve may transfer the auth portion of the url when resolving between two full hosts, see #1435.
  • Unicode characters in filesystem paths are not handled consistently across platforms or Node.js APIs. See #2088, #3401 and #3519.

commits

  • [ff539c5bb5] - cluster: ignore queryServer msgs on disconnection (Santiago Gimeno) #4465
  • [00148b3de1] - deps: backport 066747e from upstream V8 (Ali Ijaz Sheikh) #4625
  • [3912b5cbda] - doc: adds usage of readline line-by-line parsing (Robert Jefe Lindstaedt) #4609
  • [102fb7d3a1] - doc: remove "above" and "below" references (Richard Sun) #4499
  • [df87176ae0] - doc: update stylesheet to match frontpage (Roman Reiss) #4621
  • [ede98d1f98] - doc: stronger suggestion for userland assert (Wyatt Preul) #4535
  • [fdfc72c977] - doc: label http.IncomingMessage as a Class (Sequoia McDowell) #4589
  • [b181e26975] - doc: document http's server.listen return value (Sequoia McDowell) #4590
  • [97aaeb8519] - doc: fix description about the latest-codename (Minwoo Jung) #4583
  • [0126615d1e] - doc: add Evan Lucas to Release Team (Evan Lucas) #4579
  • [ec73c69412] - doc: add Myles Borins to Release Team (Myles Borins) #4578
  • [e703c9a4e2] - doc: bring releases.md up to date (cjihrig) #4540
  • [ac1108d5e7] - doc: add missing backtick for readline (Brian White) #4549
  • [09bc0c6a05] - doc: improvements to crypto.markdown copy (James M Snell) #4435
  • [787c5d96bd] - http: remove variable redeclaration (Rich Trott) #4612
  • [145b66820f] - module: move unnecessary work for early return (Andres Suarez) #3579
  • [ffb7deb443] - net: remove hot path comment from connect (Evan Lucas) #4648
  • [799aa74d90] - net: fix dns lookup for android (Josh Dague) #4580
  • [9accebe087] - net, doc: fix line wrapping lint in net.js (James M Snell) #4588
  • [37a546b490] - src: remove redeclarations of variables (Rich Trott) #4605
  • [b515ccc2a1] - stream: remove useless if test in transform (zoubin) #4617
  • [ea6e26d904] - test: remove duplicate fork module import (Rich Trott) #4634
  • [b14b2aec5e] - test: require common module only once (Rich Trott) #4611
  • [f28a640505] - test: only include http module once (Rich Trott) #4606
  • [6f9a96f497] - test: fix flaky unrefed timers test (Rich Trott) #4599
  • [b70eec8f7b] - tls_legacy: do not read on OpenSSL's stack (Fedor Indutny) #4624

Fishrock123 commented Jan 11, 2016

Copy link
Copy Markdown
Contributor

lib: Use arrow functions instead of bind where possible (Minwoo Jung) node#3622.

I feel really really silly that I listed that in the last release but didn't actually have it..

Maybe say - (Mistakenly missing from v5.4.0) below that line?

Fishrock123 commented Jan 11, 2016

Copy link
Copy Markdown
Contributor

Also could you fix that url shortening so it is #3622 instead of node#3622?

MylesBorins pushed a commit that referenced this pull request Jan 11, 2016
2016-01-11, Version 5.4.1 (Stable)
002b9f8 
Notable Changes:

* Minor performance improvements:
  - lib: Use arrow functions instead of bind where possible (Minwoo Jung) #3622.
    - (Mistakenly missing from v5.4.0)
  - module: move unnecessary work for early return (Andres Suarez) #3579
* Various doc fixes
* Various test improvements

PR-URL: #4626

MylesBorins commented Jan 11, 2016

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/1194/

mscdex added the meta Issues and PRs related to the general management of the project. label Jan 11, 2016

Fishrock123 commented Jan 11, 2016

Copy link
Copy Markdown
Contributor

https://ci.nodejs.org/job/node-test-binary-arm/535/RUN_SUBSET=2,nodes=pi1-raspbian-wheezy/tapTestReport/test.tap-81/

not ok 81 test-net-pipe-connect-errors.js
# fs.js:1045
# return binding.chmod(pathModule._makeLong(path), modeNum(mode));
# ^
# 
# Error: ENOENT: no such file or directory, chmod '/home/iojs/build/workspace/node-test-binary-arm/RUN_SUBSET/addons/nodes/pi1-raspbian-wheezy/test/tmp.0/test.sock'
# at Error (native)
# at Object.fs.chmodSync (fs.js:1045:18)
# at Server.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/RUN_SUBSET/addons/nodes/pi1-raspbian-wheezy/test/parallel/test-net-pipe-connect-errors.js:71:8)
# at Server.g (events.js:260:16)
# at emitNone (events.js:67:13)
# at Server.emit (events.js:166:7)
# at emitListeningNT (net.js:1263:10)
# at nextTickCallbackWith1Arg (node.js:463:9)
# at process._tickCallback (node.js:385:17)
# at Function.Module.runMain (module.js:431:11)

MylesBorins commented Jan 11, 2016

Copy link
Copy Markdown
Contributor Author

Arm-fanned job is running again

https://ci.nodejs.org/job/node-test-commit-arm-fanned/1046/

edit: Looks like that failure is consistent.

edit: ran on v5.4.0 and also had failure.
https://ci.nodejs.org/job/node-test-binary-arm/541/RUN_SUBSET=2,nodes=pi1-raspbian-wheezy/tapTestReport/test.tap-81/

edit: ran on v5.3.0 and there are no failures

MylesBorins commented Jan 11, 2016

Copy link
Copy Markdown
Contributor Author

The failures might be related to d46d850

@Trott ^^^

edit: started arm fanned job testing a branch with the potentially offending commit reverted

https://ci.nodejs.org/job/node-test-commit-arm-fanned/1052/

Trott commented Jan 11, 2016

Copy link
Copy Markdown
Member

@jbergstroem Any idea what the issue might be with the above CI failure? I want to rule out a problem with CI passing in environment variables or whatever before I look at the code (which I can't do until later anyway...)

Trott commented Jan 11, 2016

Copy link
Copy Markdown
Member

Looks like it fails with the code reverted as well but fails differently? Woot, sort of, I guess...

MylesBorins commented Jan 11, 2016

Copy link
Copy Markdown
Contributor Author

I'm mostly finding it super odd how v5.3 passes, v5.4 / 5.4.1 fails, but master passses

WUT

MylesBorins commented Jan 11, 2016

Copy link
Copy Markdown
Contributor Author

@jbergstroem has attempted to change something in CI. Running again to see if it is fixed

--> https://ci.nodejs.org/job/node-test-commit-arm-fanned/1056/

MylesBorins commented Jan 11, 2016

Copy link
Copy Markdown
Contributor Author

The above test had an unrelated failure (well unrelated to past failures). Running the full CI one more time because

https://ci.nodejs.org/job/node-test-pull-request/1201/

jbergstroem commented Jan 12, 2016

Copy link
Copy Markdown
Member

so, he latest arm fails is because the build volume is mounted in a different folder than the temp directory; i'll look at fixing that locally. so; "expected fail would pass"

jbergstroem commented Jan 12, 2016

Copy link
Copy Markdown
Member

..and as for windows, we have a slave connection issue. Current state looks good to me.

MylesBorins commented Jan 12, 2016

Copy link
Copy Markdown
Contributor Author

One more time: https://ci.nodejs.org/job/node-test-pull-request/1202/

jbergstroem commented Jan 12, 2016

Copy link
Copy Markdown
Member

✅ full green!

rvagg commented Jan 12, 2016

Copy link
Copy Markdown
Member

@nodejs/build @Fishrock123 did we get ssh keys for the new release team members on to the server in ~dist yet? I'm catching up now but this is required in order for @thealphanerd to get this released and I haven't seen a discussion about that.

MylesBorins commented Jan 12, 2016

Copy link
Copy Markdown
Contributor Author

Running CITGM: https://ci.nodejs.org/job/thealphanerd-smoker/28/

Fishrock123 commented Jan 12, 2016

Copy link
Copy Markdown
Contributor

@nodejs/build Uh oh, I don't think so. I was going to do it alongside adding the keys to the readme, but those were merged so fast I didn't get to look at them and forgot about it...

MylesBorins commented Jan 12, 2016

Copy link
Copy Markdown
Contributor Author

The test suite for tape is failing on fedora 23. Rerunning for 5.4.0 to see if this is new

https://ci.nodejs.org/job/thealphanerd-smoker/30/

jasnell and others added 7 commits January 12, 2016 10:39
doc: improvements to crypto.markdown copy
09bc0c6 
General improvements to crypto.markdown including new and
revised examples.

PR-URL: #4435
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
doc: add missing backtick for readline
ac1108d 
PR-URL: #4549
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
doc: bring releases.md up to date
e703c9a 
Refs: #3254
PR-URL: #4540
Reviewed-By: James M Snell <jasnell@gmail.com>
doc: add Myles Borins to Release Team
ec73c69 
Adds Myles Borins and his public key to the README

PR-URL: #4578
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
doc: add Evan Lucas to Release Team
0126615 
Adds Evan Lucas and his public key to the README for releases

PR-URL: #4579
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
cluster: ignore queryServer msgs on disconnection
ff539c5 
It avoids the creation of unnecessary handles. This issue is causing
intermitent failures in `test-cluster-disconnect-race` on `FreeBSD`
and `OS X`.

The problem is that the `worker2.disconnect` is being called on the
master before the `queryServer` is handled, causing the worker to
be deleted, then the Server handle is created afterwards. Later on,
when `removeWorker` is called from the `exit` handler, there are no
workers left, but one handle, thus the `AssertionError`.

Add a new `test/sequential/test-cluster-disconnect-leak` based on
`test-cluster-disconnect-race` that creates lots of workers and fails
consistently without this patch.

PR-URL: #4465
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
doc: fix description about the latest-codename
97aaeb8 
fix description about the latest LTS release download page
to make it clear

PR-URL: #4583
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott and others added 9 commits January 12, 2016 10:39
test: only include http module once
f28a640 
A few tests in test/gc include the http module twice. Remove duplicate
require().

PR-URL: #4606
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
module: move unnecessary work for early return
145b668 
The exts and trailingSlash variables are only used if the
path isn't cached. This commit moves them further down in the
code, and changes from var to const.

PR-URL: #3579
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
test: require common module only once
b14b2ae 
Two tests were requiring the common module twice. This removes the
duplicate require statement in the tests.

PR-URL: #4611
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
src: remove redeclarations of variables
37a546b 
Remove redeclarations of variables in node.js. This includes removing
one apparently unnecessary `NativeModule.require('module')`.

PR-URL: #4605
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
http: remove variable redeclaration
787c5d9 
In lib/_http_client.js, the variable `conn` was declared with the `var`
keyword three times in the same scope. This change eliminates the
variable entirely.

PR-URL: #4612
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
doc: adds usage of readline line-by-line parsing
3912b5c 
In order to make developers aware of node-core built-in
functionality, which might replace module APIs, we should
add an example of readline`s interface usage.
SEO will eventually aid this goal, since it is well searched
on Q&A sites.

PR-URL: #4609
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>>
tls_legacy: do not read on OpenSSL's stack
b70eec8 
Do not attempt to read data from the socket whilst on OpenSSL's stack,
weird things may happen, and this is most likely going to result in some
kind of error.

PR-URL: #4624
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
net: remove hot path comment from connect
ffb7deb 
This comment was added with an assumption that we could determine the
IP address that localhost should resolve to without performing a
lookup. This was a false assumption and should be removed.

PR-URL: #4648
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
test: remove duplicate fork module import
ea6e26d 
`fork` is imported twice in a row. Remove duplication.

PR-URL: #4634
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

MylesBorins commented Jan 12, 2016

Copy link
Copy Markdown
Contributor Author

Rebase against v5.x to get backported v8 fix. Added two new commits from master. Backed out commit for arrow functions to see if that was what was breaking fedora 23 on citgm.

CI: https://ci.nodejs.org/job/node-test-pull-request/1206/
CITGM: https://ci.nodejs.org/job/thealphanerd-smoker/34/

edit: CI failures on PPC appear to all be timeout related, I'm going to write them off as unrelated
edit: CI failures on windows appear to be related to system outages or communication problems, systems never connected
edit: citgm is now all green

MylesBorins commented Jan 12, 2016

Copy link
Copy Markdown
Contributor Author

One more CI run before the Build group meeting. will cut release after assuming all green

https://ci.nodejs.org/job/node-test-pull-request/1207/

edit: @mhdawson can you look at the PPC failures we are getting here. What is causing these timeouts?

Myles Borins added 2 commits January 12, 2016 12:48
2016-01-12, Version 5.4.1 (Stable)
ff99203 
Notable Changes:

* Minor performance improvements:
  - module: move unnecessary work for early return (Andres Suarez) #3579
* Various bug fixes
* Various doc fixes
* Various test improvements

PR-URL: #4626
Working on v5.4.2
e7d1c69

MylesBorins commented Jan 12, 2016

Copy link
Copy Markdown
Contributor Author

Running release job: https://ci.nodejs.org/job/iojs+release/339/

Starefossen mentioned this pull request Jan 12, 2016
Merged
MylesBorins merged commit e7d1c69 into v5.x Jan 12, 2016
MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
2016-01-12, Version 5.4.1 (Stable)
a254507 
Notable Changes:

* Minor performance improvements:
  - module: move unnecessary work for early return (Andres Suarez) #3579
* Various bug fixes
* Various doc fixes
* Various test improvements

PR-URL: #4626
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Starefossen commented Jan 13, 2016

Copy link
Copy Markdown
Member

@thealphanerd which key was used to sign this release? The new key from #4657?

rvagg commented Jan 13, 2016

Copy link
Copy Markdown
Member

@Starefossen this one was signed by @Fishrock123 on behalf of @thealphanerd, so you can go ahead without any change for Docker for now and it should be fine.

$ git tag -v v5.4.1
object ff992037246010fdad6f72323fe556da69640531
type commit
tag v5.4.1
tagger Jeremiah Senkpiel <fishrock123@rocketmail.com> 1452641853 -0500

2016-01-12 Node.js v5.4.1 (Stable) Release
gpg: Signature made Wed 13 Jan 10:37:43 2016 AEDT using RSA key ID 813DAE8E
gpg: Good signature from "keybase.io/fishrock <fishrock@keybase.io>"
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: FD3A 5288 F042 B685 0C66  B31F 09FE 4473 4EB7 990E
     Subkey fingerprint: 50CB D045 6807 04B1 B723  6935 45F5 EEBD 813D AE8E

$ curl https://nodejs.org/download/release/v5.4.1/SHASUMS256.txt.asc | gpg
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3371  100  3371    0     0   4421      0 --:--:-- --:--:-- --:--:--  4418
c523472a5972823e8b6baf2419f837885321c772612ec508a65614c758e25a46  node-v5.4.1-darwin-x64.tar.gz
c4c721d7ef2fba4e5b21dfc8017bda10c8a4d8ff322f7545e74943ca9828ee89  node-v5.4.1-darwin-x64.tar.xz
fd91d8fcbe72c76d1e58ddb3ba8bc08073c8c1e6d595bfe4b8b22e9b92855ed7  node-v5.4.1-headers.tar.gz
17424fc015dc668480537fd32f67f4d85d6e78e37f87d5eef58ef12d40bcd335  node-v5.4.1-headers.tar.xz
362ae4539b6be075b6757ba689f0ae522cfc9340c81061aca880f92fce9595c7  node-v5.4.1-linux-arm64.tar.gz
40f8e6485759a5c5f166745f7d8f33285ef425d2fe569d085220fd954fb790b9  node-v5.4.1-linux-arm64.tar.xz
21617e86758f1f95a3b9444be965aa87907410d786529cfd6aa2169ab7b5e15b  node-v5.4.1-linux-armv6l.tar.gz
2698fdd1bcfb2234f65b786c0a46ac29bf2c301c992fd72045fd03553a57e298  node-v5.4.1-linux-armv6l.tar.xz
af36dff32934dea9446673a5453efcda6e4621ce7fa73e0a401f1444c2f929af  node-v5.4.1-linux-armv7l.tar.gz
09b346ee665e3510fe8679df95bc32e8dda5953e05807c21816a25b9f5969dd4  node-v5.4.1-linux-armv7l.tar.xz
1880f3421da5579678803a523c314b345f5db00799b51b7fd9484a3248efc068  node-v5.4.1-linux-x64.tar.gz
9d264641df98742246bfd868e84cf98f649077f31eeae58931a31b0b5eee05a0  node-v5.4.1-linux-x64.tar.xz
184790d2ec8f95a75e7e746b3007e848aeba91be14ad7cec415b425df0df92e5  node-v5.4.1-linux-x86.tar.gz
a18707f7ac559563220e3319f251a2a5479b8445538f757df3a6c2dead007f1b  node-v5.4.1-linux-x86.tar.xz
059aae464e48cc11c5af1a12f47e6859da28b0fcf794f5c33d14ab7235fee1db  node-v5.4.1.pkg
956b3b0790b5742765966c6851e43c6fca298ecfb8c7102fd87e5fb6294bebd4  node-v5.4.1-sunos-x64.tar.gz
5644e5998d58bfac337a7c8672de68ec0a6dc55366a098b2364b9fbad6b345d8  node-v5.4.1-sunos-x64.tar.xz
a3eb11d58760b4b9007ac882c02e7608549fe7f65124ca90a387ba71c524b3e2  node-v5.4.1-sunos-x86.tar.gz
b8e78738f2714e34705eebd207400af422cee0842e7c599ab5077a4e51ed8453  node-v5.4.1-sunos-x86.tar.xz
78455ef2e3dea06b7d13d393c36711009048a91e5de5892523ec4a9be5a55e0c  node-v5.4.1.tar.gz
4e7d3fdfeac85c46ddaef0224695620f218e7a178e97d6e210d6d643483f1d53  node-v5.4.1.tar.xz
a65a1eaeb1bd234516232803839ef5a2f6526730abfef98724c103f76a8b5440  node-v5.4.1-x64.msi
d06e7a697d7519b83dbaf631ad45103f8768f6bfef13fa3ce8bddba9d9f436f2  node-v5.4.1-x86.msi
85311ba0ce30a6f41c6d677c33f4c198e3a3f4a4e62754a84c6c3036a1fc6e4f  win-x64/node.exe
e2715e5383d61c67d4f7d41f1fc760ef311c89b365b931720a452f1409ccabb4  win-x64/node.lib
3edae51060629596c592e2bee4da15a4b3f7e36f0cb80c8a2fd6eedcefd0de13  win-x86/node.exe
0dbb491180a380170bb89dc6976207c96c50aaf849021c7b049065c169fd09ef  win-x86/node.lib
gpg: Signature made Wed 13 Jan 10:45:09 2016 AEDT using RSA key ID 813DAE8E
gpg: Good signature from "keybase.io/fishrock <fishrock@keybase.io>"
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: FD3A 5288 F042 B685 0C66  B31F 09FE 4473 4EB7 990E
     Subkey fingerprint: 50CB D045 6807 04B1 B723  6935 45F5 EEBD 813D AE8E

rvagg deleted the v5.4.1-propose branch January 13, 2016 08:58
Starefossen pushed a commit to Starefossen/docker-node that referenced this pull request Jan 13, 2016
Upgrade Node to 5.4.1
4bc77d4 
PR-URL: nodejs#86

Related: nodejs/node#4626

Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
Starefossen mentioned this pull request Jan 13, 2016
Merged
Starefossen pushed a commit to Starefossen/official-images that referenced this pull request Jan 13, 2016
Upgrade Node to v5.4.1
951b95a 
PR-URL: docker-library#1336

Related: nodejs/node#4626
Related: nodejs/docker-node#86

Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
Starefossen mentioned this pull request Jan 13, 2016
Merged
Starefossen pushed a commit to Starefossen/official-images that referenced this pull request Jan 13, 2016
Update Node to v5.4.1
5599551 
PR-URL: docker-library#1337

Related: nodejs/node#4626
Related: nodejs/docker-node#86

Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
2016-01-12, Version 5.4.1 (Stable)
253ebd5 
Notable Changes:

* Minor performance improvements:
  - module: move unnecessary work for early return (Andres Suarez) nodejs#3579
* Various bug fixes
* Various doc fixes
* Various test improvements

PR-URL: nodejs#4626
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
RichardScothern pushed a commit to RichardScothern/official-images that referenced this pull request Jun 14, 2016
Update Node to v5.4.1
fb6385b 
PR-URL: docker-library#1337

Related: nodejs/node#4626
Related: nodejs/docker-node#86

Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL