FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add the word 'Class' before incomingmessage in http docs by Sequoia · Pull Request #4589 · nodejs/node · GitHub

/ node Public

add the word 'Class' before incomingmessage in http docs - #4589

Closed
Sequoia wants to merge 1 commit into
nodejs:masterfrom
Sequoia:add-class-to-incomingmessage
ConversationCommits (1)ChecksFiles changed
Closed

add the word 'Class' before incomingmessage in http docs#4589
Sequoia wants to merge 1 commit into
nodejs:masterfrom
Sequoia:add-class-to-incomingmessage

Conversation

Sequoia commented Jan 8, 2016

Copy link
Copy Markdown
Contributor

Closes #4576

jasnell commented Jan 8, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. lts-watch-v4.x labels Jan 8, 2016

cjihrig commented Jan 8, 2016

Copy link
Copy Markdown
Contributor

LGTM, but the commit message should be updated per https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit

doc: label http.IncomingMessage as a "Class"
e328b21 
`Server`, `ServerResponse` etc. were marked as
classes, this one class was overlooked.
Sequoia force-pushed the add-class-to-incomingmessage branch from a5c8051 to e328b21 Compare January 8, 2016 18:47

Sequoia commented Jan 8, 2016

Copy link
Copy Markdown
Contributor Author

updated to add subsystem & check line length

ryansobol commented Jan 9, 2016

Copy link
Copy Markdown
Contributor

LGTM, although I'm not sure the backticks in the commit message are necessary

silverwind pushed a commit that referenced this pull request Jan 11, 2016
doc: label http.IncomingMessage as a Class
b40aca1 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

silverwind commented Jan 11, 2016

Copy link
Copy Markdown
Contributor

LGTM, landed in b40aca1.

And yeah, we don't usually do backticks in commit messages, no specific reason. I left them out 😉

silverwind closed this Jan 11, 2016
MylesBorins pushed a commit that referenced this pull request Jan 11, 2016
doc: label http.IncomingMessage as a Class
6f2e28a 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins mentioned this pull request Jan 11, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jan 12, 2016
doc: label http.IncomingMessage as a Class
fdfc72c 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
doc: label http.IncomingMessage as a Class
367a13d 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
doc: label http.IncomingMessage as a Class
f2fa2d3 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
doc: label http.IncomingMessage as a Class
70791ae 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

rvagg commented Jan 18, 2016

Copy link
Copy Markdown
Member

First commit to core for you @Sequoia, as far as I can tell. A small one but even minor doc fixes are always appreciated. Thanks!

Sequoia commented Jan 18, 2016

Copy link
Copy Markdown
Contributor Author

@rvagg the pleasure is all mine! 😸

MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
doc: label http.IncomingMessage as a Class
bd31740 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
doc: label http.IncomingMessage as a Class
ac96253 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: nodejs#4589
Fixes: nodejs#4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL