FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove duplicate fork module import by Trott · Pull Request #4634 · nodejs/node · GitHub

/ node Public

test: remove duplicate fork module import - #4634

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:redecl-fork
Closed

test: remove duplicate fork module import#4634
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:redecl-fork

Conversation

Trott commented Jan 11, 2016

Copy link
Copy Markdown
Member

fork is imported twice in a row. Remove duplication.

`fork` is imported twice in a row. Remove duplication.
Trott added the test Issues and PRs related to the tests. label Jan 11, 2016

Copy link
Copy Markdown
Member

LGTM

mscdex added the child_process Issues and PRs related to the child_process subsystem. label Jan 12, 2016

cjihrig commented Jan 12, 2016

Copy link
Copy Markdown
Contributor

LGTM

2 similar comments

mscdex commented Jan 12, 2016

Copy link
Copy Markdown
Contributor

LGTM

targos commented Jan 12, 2016

Copy link
Copy Markdown
Member

LGTM

targos pushed a commit that referenced this pull request Jan 12, 2016
`fork` is imported twice in a row. Remove duplication.

PR-URL: #4634
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

targos commented Jan 12, 2016

Copy link
Copy Markdown
Member

landed in 0f3d75e

targos closed this Jan 12, 2016
MylesBorins pushed a commit that referenced this pull request Jan 12, 2016
`fork` is imported twice in a row. Remove duplication.

PR-URL: #4634
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
MylesBorins mentioned this pull request Jan 12, 2016

Copy link
Copy Markdown
Contributor

another fix has already landed on LTS making this one moot. Adding to ignore list

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
`fork` is imported twice in a row. Remove duplication.

PR-URL: nodejs#4634
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Trott deleted the redecl-fork branch January 13, 2022 22:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL