FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix description about the latest-codename by JungMinu · Pull Request #4583 · nodejs/node · GitHub

/ node Public

doc: fix description about the latest-codename - #4583

Closed
JungMinu wants to merge 1 commit into
masterfrom
JungMinu-patch-codename
Closed

doc: fix description about the latest-codename#4583
JungMinu wants to merge 1 commit into
masterfrom
JungMinu-patch-codename

Conversation

JungMinu commented Jan 8, 2016

Copy link
Copy Markdown
Member

fix description about the latest LTS release download page
to make it clear

fix description about the latest LTS release download page
to make it clear
JungMinu added the doc Issues and PRs related to the documentations. label Jan 8, 2016
JungMinu self-assigned this Jan 8, 2016

rvagg commented Jan 8, 2016

Copy link
Copy Markdown
Member

I guess this was my stuff-up, thanks for fixing, lgtm

cjihrig commented Jan 8, 2016

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment

jasnell commented Jan 8, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell commented Jan 8, 2016

Copy link
Copy Markdown
Member

@JungMinu ... quick nit.. not sure if you noticed but you created the branch for this in the main nodejs/node repo. We want to try to avoid folks creating branches in the main repo for PRs.

JungMinu added a commit that referenced this pull request Jan 8, 2016
fix description about the latest LTS release download page
to make it clear

PR-URL: #4583
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Jan 8, 2016

Copy link
Copy Markdown
Member

Landed in fde18b2

jasnell closed this Jan 8, 2016
MylesBorins pushed a commit that referenced this pull request Jan 11, 2016
fix description about the latest LTS release download page
to make it clear

PR-URL: #4583
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Jan 11, 2016

Copy link
Copy Markdown
Member Author

@jasnell sorry, it was a mistake

JungMinu deleted the JungMinu-patch-codename branch January 12, 2016 01:30
MylesBorins pushed a commit that referenced this pull request Jan 12, 2016
fix description about the latest LTS release download page
to make it clear

PR-URL: #4583
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Jan 12, 2016

Copy link
Copy Markdown
Member

No worries @JungMinu :-) I've done it before too

MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
fix description about the latest LTS release download page
to make it clear

PR-URL: #4583
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
fix description about the latest LTS release download page
to make it clear

PR-URL: #4583
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
fix description about the latest LTS release download page
to make it clear

PR-URL: #4583
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
fix description about the latest LTS release download page
to make it clear

PR-URL: #4583
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
fix description about the latest LTS release download page
to make it clear

PR-URL: nodejs#4583
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL