FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: Adds usage of readline line-by-line parsing by eljefedelrodeodeljefe · Pull Request #4609 · nodejs/node · GitHub

/ node Public

docs: Adds usage of readline line-by-line parsing - #4609

Closed
eljefedelrodeodeljefe wants to merge 2 commits into
nodejs:masterfrom
eljefedelrodeodeljefe:docs/example-readline-line-by-line
ConversationCommits (2)ChecksFiles changed
Closed

docs: Adds usage of readline line-by-line parsing#4609
eljefedelrodeodeljefe wants to merge 2 commits into
nodejs:masterfrom
eljefedelrodeodeljefe:docs/example-readline-line-by-line

Conversation

eljefedelrodeodeljefe commented Jan 10, 2016

Copy link
Copy Markdown
Contributor

In order to make developers aware of node-core built-in
functionality, which might replace module APIs, we should
add an example of readline`s interface usage.
SEO will eventually aid this goal, since it is well searched
on Q&A sites.

PR-URL: #4609
Reviewed-By:

eljefedelrodeodeljefe mentioned this pull request Jan 10, 2016
Closed
mscdex added doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module. labels Jan 10, 2016

mscdex commented Jan 10, 2016

Copy link
Copy Markdown
Contributor

I think it may be better to include the new example after the one at the top of the document.

docs: Adds usage of readline line-by-line parsing
89b2254 
In order to make developers aware of node-core built-in
functionality, which might replace module APIs, we should
add an example of readline`s interface usage.
SEO will eventually aid this goal, since it is well searched
on Q&A sites.

PR-URL: #4609
Reviewed-By:

eljefedelrodeodeljefe commented Jan 10, 2016

Copy link
Copy Markdown
Contributor Author

Okay, thanks. Did this in 89b2254. I force pushed the commit, but apparently it didn't update in the PR. Won't do this again...

eljefedelrodeodeljefe commented Jan 11, 2016

Copy link
Copy Markdown
Contributor Author

@silverwind I agree. Wasn't sure there. Did this in 228dd24. Thanks.

silverwind commented Jan 11, 2016

Copy link
Copy Markdown
Contributor

LGTM

ryansobol commented Jan 11, 2016

Copy link
Copy Markdown
Contributor

LGTM, although you might want to squash the commits down to just one.

silverwind commented Jan 11, 2016

Copy link
Copy Markdown
Contributor

Squashing is not an issue, we do that when landing. I acutally prefer them unsquashed so one can track changes that happens during the PRs lifetime.

eljefedelrodeodeljefe commented Jan 11, 2016

Copy link
Copy Markdown
Contributor Author

Okay. Looking at the process, I'd prefer it unsquashed also, in general. However you want it...

ryansobol commented Jan 11, 2016

Copy link
Copy Markdown
Contributor

Makes sense. :)

jasnell commented Jan 11, 2016

Copy link
Copy Markdown
Member

LGTM

silverwind pushed a commit that referenced this pull request Jan 11, 2016
doc: adds usage of readline line-by-line parsing
5a53cba 
In order to make developers aware of node-core built-in
functionality, which might replace module APIs, we should
add an example of readline`s interface usage.
SEO will eventually aid this goal, since it is well searched
on Q&A sites.

PR-URL: #4609
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>>

silverwind commented Jan 11, 2016

Copy link
Copy Markdown
Contributor

Thanks! Landed in 5a53cba.

silverwind closed this Jan 11, 2016

eljefedelrodeodeljefe commented Jan 11, 2016

Copy link
Copy Markdown
Contributor Author

Cool. Thanks @silverwind . Will delete the branch then.

eljefedelrodeodeljefe deleted the docs/example-readline-line-by-line branch January 11, 2016 19:40
MylesBorins pushed a commit that referenced this pull request Jan 11, 2016
doc: adds usage of readline line-by-line parsing
5341b5f 
In order to make developers aware of node-core built-in
functionality, which might replace module APIs, we should
add an example of readline`s interface usage.
SEO will eventually aid this goal, since it is well searched
on Q&A sites.

PR-URL: #4609
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>>
MylesBorins mentioned this pull request Jan 11, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jan 12, 2016
doc: adds usage of readline line-by-line parsing
3912b5c 
In order to make developers aware of node-core built-in
functionality, which might replace module APIs, we should
add an example of readline`s interface usage.
SEO will eventually aid this goal, since it is well searched
on Q&A sites.

PR-URL: #4609
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>>
MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
doc: adds usage of readline line-by-line parsing
d9768a4 
In order to make developers aware of node-core built-in
functionality, which might replace module APIs, we should
add an example of readline`s interface usage.
SEO will eventually aid this goal, since it is well searched
on Q&A sites.

PR-URL: #4609
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
doc: adds usage of readline line-by-line parsing
8baa2a9 
In order to make developers aware of node-core built-in
functionality, which might replace module APIs, we should
add an example of readline`s interface usage.
SEO will eventually aid this goal, since it is well searched
on Q&A sites.

PR-URL: #4609
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
doc: adds usage of readline line-by-line parsing
909df52 
In order to make developers aware of node-core built-in
functionality, which might replace module APIs, we should
add an example of readline`s interface usage.
SEO will eventually aid this goal, since it is well searched
on Q&A sites.

PR-URL: #4609
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>>

rvagg commented Jan 18, 2016

Copy link
Copy Markdown
Member

I think this is your first commit to core @eljefedelrodeodeljefe, welcome on board! It looks like you're already getting comfortable in the docs, we appreciate it and hope you're able to grok the processes and preferences around here, let us know if you need help on that front.

MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
doc: adds usage of readline line-by-line parsing
2f40715 
In order to make developers aware of node-core built-in
functionality, which might replace module APIs, we should
add an example of readline`s interface usage.
SEO will eventually aid this goal, since it is well searched
on Q&A sites.

PR-URL: #4609
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>>
MylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
doc: adds usage of readline line-by-line parsing
7f51e15 
In order to make developers aware of node-core built-in
functionality, which might replace module APIs, we should
add an example of readline`s interface usage.
SEO will eventually aid this goal, since it is well searched
on Q&A sites.

PR-URL: nodejs#4609
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>>

matthiasg commented Jun 6, 2018

Copy link
Copy Markdown

It would have been great had this new documentation also included information on how to process each line asynchronously

bnoordhuis mentioned this pull request Nov 19, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL