FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: mention that http.Server inherits from net.Server by ryansobol · Pull Request #4455 · nodejs/node · GitHub

/ node Public

doc: mention that http.Server inherits from net.Server - #4455

Closed
ryansobol wants to merge 1 commit into
nodejs:masterfrom
ryansobol:http_server_doc
ConversationCommits (1)ChecksFiles changed
Closed

doc: mention that http.Server inherits from net.Server#4455
ryansobol wants to merge 1 commit into
nodejs:masterfrom
ryansobol:http_server_doc

Conversation

ryansobol commented Dec 28, 2015

Copy link
Copy Markdown
Contributor

As a Node beginner, it wasn't immediately obvious to me that http.Server inherits from net.Server until I read the source.

r-52 added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. labels Dec 28, 2015

mscdex commented Dec 28, 2015

Copy link
Copy Markdown
Contributor

Maybe we can just drop the "This is an EventEmitter" part since the docs for net.Server already say that. Perhaps it might read something like:

This class inherits from net.Server and has the following additional events:

ryansobol commented Dec 29, 2015

Copy link
Copy Markdown
Contributor Author

That's fine by me. I was just following the precedence set in a few other places.

The pull request has been updated.

cjihrig commented Dec 29, 2015

Copy link
Copy Markdown
Contributor

LGTM. Can you update the commit message according to https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit.

ryansobol commented Dec 29, 2015

Copy link
Copy Markdown
Contributor Author

Done. And thanks for the link.

ryansobol changed the title Mention that http.Server inherits from net.Server doc: mention that http.Server inherits from net.Server Dec 29, 2015

mscdex commented Dec 29, 2015

Copy link
Copy Markdown
Contributor

LGTM

3 similar comments

MylesBorins commented Dec 29, 2015

Copy link
Copy Markdown
Contributor

LGTM

Qard commented Dec 30, 2015

Copy link
Copy Markdown
Member

LGTM

jasnell commented Dec 30, 2015

Copy link
Copy Markdown
Member

LGTM

jasnell pushed a commit that referenced this pull request Dec 30, 2015
doc: mention that http.Server inherits from net.Server
4e8a005 
PR-URL: #4455
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Dec 30, 2015

Copy link
Copy Markdown
Member

Landed in 4e8a005

jasnell closed this Dec 30, 2015
ryansobol deleted the http_server_doc branch December 31, 2015 19:06

rvagg commented Jan 4, 2016

Copy link
Copy Markdown
Member

Thanks for the contribution @ryansobol! I believe this is your first commit to core and I see a few other PRs from you as well, it's great to see you jumping right in. Please holler if you need any help landing your other work. I hope you continue to find ways to contribute and stick around.

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
doc: mention that http.Server inherits from net.Server
eee5082 
PR-URL: nodejs#4455
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 28, 2016
doc: mention that http.Server inherits from net.Server
d6c83f0 
PR-URL: #4455
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
doc: mention that http.Server inherits from net.Server
ac1e89b 
PR-URL: #4455
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
doc: mention that http.Server inherits from net.Server
0eefe24 
PR-URL: nodejs#4455
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Feb 11, 2016
Merged
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 15, 2016
doc: mention that http.Server inherits from net.Server
437d0e3 
PR-URL: nodejs#4455
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
doc: mention that http.Server inherits from net.Server
e6bd940 
PR-URL: nodejs#4455
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
leonardoadame mentioned this pull request May 16, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL