lib: Remove unnecessary TODO comments - #4719
Conversation
Sorry, something went wrong.
|
LGTM The mentor who is available is probably @Fishrock123. (I'm inferring this from the fact that he's the one that added the mentor-available tag.) But yes, directing questions about #4642 to that actual issue is definitely the thing to do. I'm happy to help too, at least on areas of the code where I feel comfortable. And there are probably others too. If you want to try as many venues as possible, you can also try asking in the #node-dev IRC channel. |
Sorry, something went wrong.
Original committer stated they were safe to remove in issue post. Ref: Issue nodejs#4642
|
Rebased on latest master. |
Sorry, something went wrong.
|
Thanks! Landed in 83d2b77. A full CI run isn't necessary for removing a few comments, but I did run the tests locally as a sanity check. |
Sorry, something went wrong.
|
Thanks for finding a place to contribute @pgeiss, it looks like this is your first commit in core, if so, welcome on board! I hope you can find other places to make an impact. |
Sorry, something went wrong.
Refs: nodejs#4642 PR-URL: nodejs#4719 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Refs: nodejs#4642 PR-URL: nodejs#4719 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Refs: nodejs#4642 PR-URL: nodejs#4719 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Refs: nodejs#4642 PR-URL: nodejs#4719 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Original committer (@trevnorris) stated they were safe to remove in issue comments.
Ref: Issue #4642
PS: I want to work more on the TODOs in 4642 (and, you know, actually fix things). I'm assuming I should direct questions if I have any there? It has a 'mentor-available' tag.