test: add common.platformTimeout() to dgram test - #4938
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
force-pushed
the
add-platform-timeout
branch
from
f271cab to
18f930c
Compare
January 29, 2016 00:01
Use common.platformTimeout() to mitigate potential for CI to timeout on slower devices. Ref: nodejs#4937
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
CI is green. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 31, 2016
Use common.platformTimeout() to mitigate potential for CI to timeout on slower devices. Ref: nodejs#4937 PR-URL: nodejs#4938 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <mborins@us.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Use common.platformTimeout() to mitigate potential for CI to timeout on slower devices. Ref: nodejs#4937 PR-URL: nodejs#4938 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <mborins@us.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use common.platformTimeout() to mitigate potential for CI to timeout
on slower devices.
Ref: #4937