FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add CTC meeting minutes 2016-01-27 by rvagg · Pull Request #5057 · nodejs/node · GitHub

/ node Public

doc: add CTC meeting minutes 2016-01-27 - #5057

Closed
rvagg wants to merge 1 commit into
nodejs:masterfrom
rvagg:ctc-minutes-2016-01-27
Closed

doc: add CTC meeting minutes 2016-01-27#5057
rvagg wants to merge 1 commit into
nodejs:masterfrom
rvagg:ctc-minutes-2016-01-27

Conversation

mscdex added the doc Issues and PRs related to the documentations. label Feb 3, 2016
Comment thread doc/ctc-meetings/2016-01-27.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do those xes signify something?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I wasn't in this meeting but I'm taking it to mean not-present and we continued this convention in the last meeting as well. Seems like that's not clear so do you have a better suggestion that's simple for note-takers? Deleting names has proven to be annoying for various reasons, although I guess I could remove them when I PR the minutes.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe replace the x-es with (absent)?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

great, done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hmmm under the heading "Present" , we are mentioning "absent"?

Copy link
Copy Markdown
Contributor

LGTM besides question.

rvagg force-pushed the ctc-minutes-2016-01-27 branch from a152b0b to 3967cb5 Compare February 4, 2016 12:01

Mikeal: hasn’t changed recently

Ben, James: read though it recently, lgtm

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I assume it's the actual chat transcript. If so we don't have to fix these typos

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

More likely it was them expressing roughly the same thing and it was summarised in a single line for the sake of speed, it's pretty hard capturing discussion in real-time, we're not very skilled at taking it slowly!

So this is probably a typo, you're welcome to use your amazing fourth eye to point out typos and I'll happily fix them.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

:-) :-) Sure, I can point them out whenever I find :-) But then we can leave the chat transcripts as they are right? It would give the readers a feel that they are really dealing with humans, who can make mistakes just like them :D

Copy link
Copy Markdown
Member

LGTM

2 similar comments

Copy link
Copy Markdown
Contributor

LGTM

jasnell commented Feb 4, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell pushed a commit that referenced this pull request Feb 4, 2016
PR-URL: #5057
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Feb 4, 2016

Copy link
Copy Markdown
Member

Landed in ce11a37

jasnell closed this Feb 4, 2016
rvagg added a commit that referenced this pull request Feb 8, 2016
PR-URL: #5057
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#5057
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL