FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove test-cluster-* var redeclarations by Trott · Pull Request #4980 · nodejs/node · GitHub

/ node Public

test: remove test-cluster-* var redeclarations - #4980

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:test-cluster-no-redeclare
Closed

test: remove test-cluster-* var redeclarations#4980
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:test-cluster-no-redeclare

Conversation

Trott commented Jan 30, 2016

Copy link
Copy Markdown
Member

No description provided.

Trott added test Issues and PRs related to the tests. lts-watch-v4.x labels Jan 30, 2016
mscdex added the cluster Issues and PRs related to the cluster subsystem. label Jan 30, 2016

mscdex commented Jan 31, 2016

Copy link
Copy Markdown
Contributor

LGTM if CI is ok with it: https://ci.nodejs.org/job/node-test-pull-request/1452/

jasnell commented Feb 1, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell pushed a commit that referenced this pull request Feb 1, 2016
PR-URL: #4980
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Feb 1, 2016

Copy link
Copy Markdown
Member

Landed in f7feab5

jasnell closed this Feb 1, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
PR-URL: #4980
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
PR-URL: #4980
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
PR-URL: #4980
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Feb 18, 2016
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
PR-URL: #4980
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4980
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott deleted the test-cluster-no-redeclare branch January 13, 2022 22:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL