doc: don't use "interface" as a variable name - #4900
Closed
ChALkeR wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Note that some modules obviously copy-pasted it from there. For example: 2388 ewdjs-0.103.0.tgz/essentials/install.js:284: interface.question("Enter Y/N: ", function(answer) {
2388 ewdjs-0.103.0.tgz/essentials/install.js:276:interface.question('Install EWD.js to directory path (' + process.cwd() + '): ', function(installPath) {
31 typenode-0.1.1.tgz/example/readline.ts:41: interface.question('What is your favorite food?', function(answer) {
26 gtm-0.1.0-56-g1b5486c.tgz/tests/readline_gtm.js:14:interface.question(" Welcome to the GT.M prompt via Node.js ", function(answer) {
|
Sorry, something went wrong.
In readline.markdown, don't use strict mode reserved keyword "interface" as a variable name. This commit changes the name of one `readline.Interface` instance from "interface" to "rl", as it is named in other places of the doc.
ChALkeR
force-pushed
the
ChALkeR-patch-1
branch
from
261d0a9 to
c4d3e91
Compare
January 27, 2016 09:57
Copy link
Copy Markdown
Contributor
I see no problems with that. Not all modules are stict-mode compatible |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@vkurchatkin But they would be forced to take some extra steps when migrating their sources to strict mode. Also, this means that people copy-paste that, and the users of strict mode already took some extra steps after copy-pasting the example code. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@ChALkeR I mean, changing this in the docs is a good idea, but it's not a big deal that some modules have this. Some people deliberately write incompatible code |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
silverwind
pushed a commit
that referenced
this pull request
Jan 29, 2016
In readline.markdown, don't use strict mode reserved keyword "interface" as a variable name. This commit changes the name of one `readline.Interface` instance from "interface" to "rl", as it is named in other places of the doc. PR-URL: #4900 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
In readline.markdown, don't use strict mode reserved keyword "interface" as a variable name. This commit changes the name of one `readline.Interface` instance from "interface" to "rl", as it is named in other places of the doc. PR-URL: #4900 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 22, 2016
In readline.markdown, don't use strict mode reserved keyword "interface" as a variable name. This commit changes the name of one `readline.Interface` instance from "interface" to "rl", as it is named in other places of the doc. PR-URL: #4900 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 22, 2016
In readline.markdown, don't use strict mode reserved keyword "interface" as a variable name. This commit changes the name of one `readline.Interface` instance from "interface" to "rl", as it is named in other places of the doc. PR-URL: #4900 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
In readline.markdown, don't use strict mode reserved keyword "interface" as a variable name. This commit changes the name of one `readline.Interface` instance from "interface" to "rl", as it is named in other places of the doc. PR-URL: #4900 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
In readline.markdown, don't use strict mode reserved keyword "interface" as a variable name. This commit changes the name of one `readline.Interface` instance from "interface" to "rl", as it is named in other places of the doc. PR-URL: nodejs#4900 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In readline.markdown, don't use strict mode reserved keyword interface as a variable name.
This commit changes the name of one readline.Interface instance from interface to rl, as it is named in other places of the readline documentation.