FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix links order in Buffer doc by estliberitas · Pull Request #5076 · nodejs/node · GitHub

/ node Public

doc: fix links order in Buffer doc - #5076

Closed
estliberitas wants to merge 1 commit into
nodejs:masterfrom
estliberitas:doc-buffer-link-order
Closed

doc: fix links order in Buffer doc#5076
estliberitas wants to merge 1 commit into
nodejs:masterfrom
estliberitas:doc-buffer-link-order

Conversation

Copy link
Copy Markdown
Contributor

Sort links in lexical order

Sort links in lexical order
thefourtheye added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Feb 4, 2016
Comment thread doc/api/buffer.markdown
instance, while `ArrayBuffer#slice()` creates a copy of the slice,
the implementation of [`Buffer#slice()`][] creates a view over the existing
Buffer without copying, making `Buffer#slice()` far more efficient.
the implementation of [`Buffer#slice()`][`buf.slice()`] creates a view over the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why the reference also has backticks? :D

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Well, since it points to buf.slice() reference. I could do something like [buf-slice] and use it in both cases. But this way I guess I saved some characters ))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fair enough

Copy link
Copy Markdown
Contributor

LGTM cc @nodejs/documentation

Copy link
Copy Markdown

LGTM

1 similar comment

r-52 commented Feb 4, 2016

Copy link
Copy Markdown
Contributor

LGTM

jasnell commented Feb 4, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell pushed a commit that referenced this pull request Feb 4, 2016
Sort links in lexical order

PR-URL: #5076
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Feb 4, 2016

Copy link
Copy Markdown
Member

Landed in c714b2e

jasnell closed this Feb 4, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
Sort links in lexical order

PR-URL: #5076
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 9, 2016
Sort links in lexical order

PR-URL: #5076
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

stevemao commented Feb 9, 2016

Copy link
Copy Markdown
Contributor

@estliberitas you should probably join the documentation group incase you are not aware of it.

Copy link
Copy Markdown
Contributor Author

@stevemao Em, I'm not aware of this. It's not up to me as far as I recall

Copy link
Copy Markdown
Contributor

MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
Sort links in lexical order

PR-URL: #5076
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
Sort links in lexical order

PR-URL: #5076
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
estliberitas deleted the doc-buffer-link-order branch February 27, 2016 18:49
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
Sort links in lexical order

PR-URL: #5076
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Sort links in lexical order

PR-URL: nodejs#5076
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL