FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: Add assertion for TLS peer certificate fingerprint by alandotcom · Pull Request #4923 · nodejs/node · GitHub

/ node Public

test: Add assertion for TLS peer certificate fingerprint - #4923

Closed
alandotcom wants to merge 1 commit into
nodejs:masterfrom
alandotcom:test-fingerprint
ConversationCommits (1)ChecksFiles changed
Closed

test: Add assertion for TLS peer certificate fingerprint#4923
alandotcom wants to merge 1 commit into
nodejs:masterfrom
alandotcom:test-fingerprint

Conversation

alandotcom commented Jan 28, 2016

Copy link
Copy Markdown

PR-URL: #4923
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

mscdex added tls Issues and PRs related to the tls subsystem. test Issues and PRs related to the tests. labels Jan 28, 2016

bnoordhuis commented Jan 28, 2016

Copy link
Copy Markdown
Member

LGTM but can you amend the commit log so it conforms to the guidelines from CONTRIBUTING.md? In particular, it should start with the subsystem (test:).

CI: https://ci.nodejs.org/job/node-test-pull-request/1419/ (currently private because of the upcoming security release.)

alandotcom changed the title Add assertion for TLS peer certificate fingerprint test: Add assertion for TLS peer certificate fingerprint Jan 29, 2016

alandotcom commented Jan 29, 2016

Copy link
Copy Markdown
Author

Thanks @bnoordhuis. Just updated the commit message

jasnell commented Jan 29, 2016

Copy link
Copy Markdown
Member

LGTM

bnoordhuis commented Jan 29, 2016

Copy link
Copy Markdown
Member

@LumberJ Can you run make lint? The linter is complaining that:

/usr/home/iojs/build/workspace/node-test-linter/test/parallel/test-tls-peer-certificate.js
  41:1  error  Line 41 exceeds the maximum line length of 80  max-len

test: Add assertion for TLS peer certificate fingerprint
7b61f02 
PR-URL: nodejs#4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

alandotcom commented Jan 30, 2016

Copy link
Copy Markdown
Author

Thanks, just fixed the lint error.

On Fri, Jan 29, 2016 at 12:36 AM, Ben Noordhuis notifications@github.com
wrote:

@LumberJ https://github.com/lumberj Can you run make lint? The linter
is complaining that:

/usr/home/iojs/build/workspace/node-test-linter/test/parallel/test-tls-peer-certificate.js
41:1 error Line 41 exceeds the maximum line length of 80 max-len

—
Reply to this email directly or view it on GitHub
#4923 (comment).

Alan Cohen
@alan_mit https://twitter.com/intent/user?screen_name=alan_mit

jasnell pushed a commit that referenced this pull request Feb 1, 2016
test: Add assertion for TLS peer certificate fingerprint
59fb26c 
PR-URL: #4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Feb 1, 2016

Copy link
Copy Markdown
Member

Landed in 59fb26c

jasnell closed this Feb 1, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
test: Add assertion for TLS peer certificate fingerprint
0384a43 
PR-URL: #4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
test: Add assertion for TLS peer certificate fingerprint
6afd2a4 
PR-URL: #4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
test: Add assertion for TLS peer certificate fingerprint
f5d29d7 
PR-URL: #4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
test: Add assertion for TLS peer certificate fingerprint
674415b 
PR-URL: #4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
test: Add assertion for TLS peer certificate fingerprint
7af2c6e 
PR-URL: nodejs#4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL