test: move cluster tests to parallel - #4774
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Two cluster tests have recently changed so that they are no longer resource intensive. Move them back to parallel. Ref: nodejs#4736 Ref: nodejs#4739
Trott
force-pushed
the
move-to-parallel
branch
from
9f59a84 to
097ea9f
Compare
January 20, 2016 04:04
Copy link
Copy Markdown
Member
|
LGTM pre CI. Edit: we already tested this in -J no? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/1311/ I don't think we've tested this with -J. Could cherry-pick it over to your branch and do that if you'd like. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Changes LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@Trott reckon we're fine. LGTM; fails seem unrelated. |
Sorry, something went wrong.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 21, 2016
Two cluster tests have recently changed so that they are no longer resource intensive. Move them back to parallel. Ref: nodejs#4736 Ref: nodejs#4739 PR-URL: nodejs#4774 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Copy link
Copy Markdown
Member
|
@Trott ... should this be done in LTS also? |
Sorry, something went wrong.
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Two cluster tests have recently changed so that they are no longer resource intensive. Move them back to parallel. Ref: nodejs#4736 Ref: nodejs#4739 PR-URL: nodejs#4774 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two cluster tests have recently changed so that they are no longer
resource intensive. Move them back to parallel.
Ref: #4736
Ref: #4739