FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v16.x backport] stream: add isDisturbed helper by ronag · Pull Request #39819 · nodejs/node · GitHub

/ node Public

[v16.x backport] stream: add isDisturbed helper - #39819

Closed
ronag wants to merge 2 commits into
nodejs:v16.x-stagingfrom
nxtedition:backport-39628-to-v16.x
ConversationCommits (2)ChecksFiles changed
Closed

[v16.x backport] stream: add isDisturbed helper#39819
ronag wants to merge 2 commits into
nodejs:v16.x-stagingfrom
nxtedition:backport-39628-to-v16.x

Conversation

ronag commented Aug 20, 2021

Copy link
Copy Markdown
Member

No description provided.

ronag changed the title Backport 39628 to v16.x [v16.x backport] stream: add isDisturbed helper Aug 20, 2021
nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Aug 20, 2021
ronag changed the base branch from master to v16.x-staging August 20, 2021 13:30
ronag force-pushed the backport-39628-to-v16.x branch from ef6ccc1 to 574bec6 Compare August 20, 2021 13:31
ronag mentioned this pull request Aug 20, 2021
Closed
stream: add isDisturbed helper
cd6f6c8 
Adds a helper util used to determine whether a stream has been
disturbed (read or cancelled).

Refs: nodejs#39627

PR-URL: nodejs#39628
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Backport-PR-URL: nodejs#39819
ronag force-pushed the backport-39628-to-v16.x branch from 574bec6 to cd6f6c8 Compare August 20, 2021 13:38
ronag requested a review from jasnell August 20, 2021 14:00

ronag commented Aug 20, 2021

Copy link
Copy Markdown
Member Author

@nodejs/streams

ronag added stream Issues and PRs related to the stream subsystem. web streams labels Aug 20, 2021
mcollina approved these changes Aug 20, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

targos reviewed Aug 22, 2021
View reviewed changes
Comment thread lib/internal/streams/utils.js
Update lib/internal/streams/utils.js
fca6388 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2021

nodejs-github-bot commented Aug 22, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39634/

nodejs-github-bot commented Aug 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39641/

targos commented Aug 23, 2021

Copy link
Copy Markdown
Member

I think this one will be easier to do after #39563 ?

ronag commented Aug 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

I think this one will be easier to do after #39563 ?

Why? I don't think they are related? I think this can land now?

ronag commented Aug 23, 2021

Copy link
Copy Markdown
Member Author

CI linting error on markdown which I can't figure out. 😕

targos commented Aug 23, 2021

Copy link
Copy Markdown
Member

I think this one will be easier to do after #39563 ?

Why? I don't think they are related? I think this can land now?

You're right. I'm mixing things

targos commented Aug 23, 2021

Copy link
Copy Markdown
Member

CI linting error on markdown which I can't figure out. 😕

It was because 0073831 was missing from v16.x-staging. It's there now.

targos pushed a commit that referenced this pull request Aug 23, 2021
stream: add isDisturbed helper
af7047a 
Adds a helper util used to determine whether a stream has been
disturbed (read or cancelled).

Refs: #39627

PR-URL: #39628
Backport-PR-URL: #39819
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos commented Aug 23, 2021

Copy link
Copy Markdown
Member

Landed in af7047a

targos closed this Aug 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
benjamingr benjamingr approved these changes
jasnell Awaiting requested review from jasnell
+1 more reviewer
targos targos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. stream Issues and PRs related to the stream subsystem. tools Issues and PRs related to the tools directory. web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL